[HACKERS] HeapTupleSatisfiesToast not setting XMIN_COMMITTED?

2011-09-21 Thread Alvaro Herrera
Hi, I notice that HeapTupleSatisfiesToast is not setting the HEAP_XMIN_COMMITTED bit, though it is reading it. Is there a reason for this? It seems to me that it'd make sense to have it set ... unless it's set by some other routine, somehow? -- Álvaro Herrera alvhe...@alvh.no-ip.org --

Re: [HACKERS] HeapTupleSatisfiesToast not setting XMIN_COMMITTED?

2011-09-21 Thread Merlin Moncure
On Wed, Sep 21, 2011 at 1:03 PM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Hi, I notice that HeapTupleSatisfiesToast is not setting the HEAP_XMIN_COMMITTED bit, though it is reading it.  Is there a reason for this?  It seems to me that it'd make sense to have it set ... unless it's set

Re: [HACKERS] HeapTupleSatisfiesToast not setting XMIN_COMMITTED?

2011-09-21 Thread Alvaro Herrera
Excerpts from Merlin Moncure's message of mié sep 21 16:02:34 -0300 2011: On Wed, Sep 21, 2011 at 1:03 PM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Hi, I notice that HeapTupleSatisfiesToast is not setting the HEAP_XMIN_COMMITTED bit, though it is reading it.  Is there a reason

Re: [HACKERS] HeapTupleSatisfiesToast not setting XMIN_COMMITTED?

2011-09-21 Thread Merlin Moncure
On Wed, Sep 21, 2011 at 2:14 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Merlin Moncure's message of mié sep 21 16:02:34 -0300 2011: On Wed, Sep 21, 2011 at 1:03 PM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Hi, I notice that HeapTupleSatisfiesToast is not

Re: [HACKERS] HeapTupleSatisfiesToast not setting XMIN_COMMITTED?

2011-09-21 Thread Tom Lane
Alvaro Herrera alvhe...@alvh.no-ip.org writes: I notice that HeapTupleSatisfiesToast is not setting the HEAP_XMIN_COMMITTED bit, though it is reading it. Is there a reason for this? It seems to me that it'd make sense to have it set ... unless it's set by some other routine, somehow? Hmm

Re: [HACKERS] HeapTupleSatisfiesToast not setting XMIN_COMMITTED?

2011-09-21 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: More interesting, however, is the fact that the XMAX_COMMITTED bit is never set either. I guess the rows are deleted by a different mechanism (tuptoaster probably) -- it isn't obvious how this works just by looking at tqual.c. It seems to do