Re: [HACKERS] How to crash postgres using savepoints

2004-08-03 Thread Tom Lane
Gavin Sherry <[EMAIL PROTECTED]> writes: > On Tue, 3 Aug 2004, Jeff Davis wrote: >> I have a question for you also. I just posted a patch at about the same >> time you did (I sent it to pgsql-patches, but I haven't seen it appear >> yet). Mine was a one-liner (appended to end of this email) and all

Re: [HACKERS] How to crash postgres using savepoints

2004-08-03 Thread Gavin Sherry
On Tue, 3 Aug 2004, Jeff Davis wrote: > On Tue, 2004-08-03 at 03:41, Gavin Sherry wrote: > > Attached is a patch fixing this. > > > > One question I do have: > > > > if (target->savepointLevel != s->savepointLevel) > > > > Will this ever be true in the current code? I cannot see anything setti

Re: [HACKERS] How to crash postgres using savepoints

2004-08-03 Thread Jeff Davis
On Tue, 2004-08-03 at 03:41, Gavin Sherry wrote: > Attached is a patch fixing this. > > One question I do have: > > if (target->savepointLevel != s->savepointLevel) > > Will this ever be true in the current code? I cannot see anything setting > savepointLevel explicitly. >From reading the

Re: [HACKERS] How to crash postgres using savepoints

2004-08-03 Thread Gavin Sherry
Attached is a patch fixing this. One question I do have: if (target->savepointLevel != s->savepointLevel) Will this ever be true in the current code? I cannot see anything setting savepointLevel explicitly. GavinIndex: src/backend/access/transam/xact.c ==

Re: [HACKERS] How to crash postgres using savepoints

2004-08-03 Thread Jeff Davis
On Mon, 2004-08-02 at 22:37, Christopher Kings-Lynne wrote: > Did this get through? Hadn't seen anyone comment on it, and I thought > it was pretty major :P > I'd just like to second your claims. I have a snapshot from 2004-08-02 and I appended a sequence of SQL commands that causes a crash for

Re: [HACKERS] How to crash postgres using savepoints

2004-08-02 Thread Christopher Kings-Lynne
Did this get through? Hadn't seen anyone comment on it, and I thought it was pretty major :P Christopher Kings-Lynne wrote: test=# begin; BEGIN test=# savepoint "A"; SAVEPOINT test=# rollback to a; server closed the connection unexpectedly This probably means the server terminated abnorm

[HACKERS] How to crash postgres using savepoints

2004-08-02 Thread Christopher Kings-Lynne
test=# begin; BEGIN test=# savepoint "A"; SAVEPOINT test=# rollback to a; server closed the connection unexpectedly This probably means the server terminated abnormally before or while processing the request. LOG: server process (PID 45905) was terminated by signal 11 LOG: termina