Re: [HACKERS] Improvement of log messages in pg_basebackup

2012-03-28 Thread Robert Haas
On Tue, Mar 27, 2012 at 5:25 AM, Fujii Masao masao.fu...@gmail.com wrote:       fprintf(stderr, _(%s: could not identify system: %s\n),                       progname, PQerrorMessage(conn)); Since PQerrorMessage() result includes a trailing newline, the above log message in pg_basebackup

[HACKERS] Improvement of log messages in pg_basebackup

2012-03-27 Thread Fujii Masao
Hi, fprintf(stderr, _(%s: could not identify system: %s\n), progname, PQerrorMessage(conn)); Since PQerrorMessage() result includes a trailing newline, the above log message in pg_basebackup doesn't need to include a trailing \n. Attached patch gets rid of that \n.