Re: [HACKERS] Improvement of versioning on Windows, take two

2014-08-18 Thread Noah Misch
Committed after making several fixes, notably: On Thu, Aug 14, 2014 at 03:59:57PM +0900, Michael Paquier wrote: --- a/src/test/isolation/Makefile +++ b/src/test/isolation/Makefile @@ -6,12 +6,15 @@ subdir = src/test/isolation top_builddir = ../../.. include

Re: [HACKERS] Improvement of versioning on Windows, take two

2014-08-18 Thread Michael Paquier
On Tue, Aug 19, 2014 at 12:34 PM, Noah Misch n...@leadboat.com wrote: Committed after making several fixes, notably: Thanks a lot, especially for the additional comments. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Improvement of versioning on Windows, take two

2014-08-14 Thread Michael Paquier
On Tue, Aug 12, 2014 at 11:47 PM, MauMau maumau...@gmail.com wrote: From: Michael Paquier michael.paqu...@gmail.com Yes, the build succeeded. I confirmed that the following files have version info. However, unlike other files, they don't have file description. Is this intended?

Re: [HACKERS] Improvement of versioning on Windows, take two

2014-08-14 Thread MauMau
I confirmed that all issues are solved. The patch content looks good, alghouth I'm not confident in Perl. I marked this patch as ready for committer. I didn't try the patch on MinGW. Regards MauMau -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] Improvement of versioning on Windows, take two

2014-08-12 Thread MauMau
From: Michael Paquier michael.paqu...@gmail.com Oh yes, right. I don't really know how I missed this error when testing v1. Adding an explicit call to RemoveFile('src\timezone\win32ver.rc') for project postgres calms down the build. Is the attached working for you? Yes, the build succeeded. I

Re: [HACKERS] Improvement of versioning on Windows, take two

2014-08-11 Thread Michael Paquier
On Sun, Aug 10, 2014 at 9:31 PM, MauMau maumau...@gmail.com wrote: From: Michael Paquier michael.paqu...@gmail.com LINK : fatal error LNK1104: ファイル '.\release\postgres\src_timezone_win32ver.obj' を開くことができません。 Oh yes, right. I don't really know how I missed this error when testing v1. Adding an

Re: [HACKERS] Improvement of versioning on Windows, take two

2014-08-10 Thread MauMau
From: Michael Paquier michael.paqu...@gmail.com Please find attached a patch finishing the work begun during CF1. This adds versioning support for all the remaining dll and exe files on both MinGW and MSVC: - regress.dll (MSVC only) - isolationtester.exe - pg_isolation_regress.exe -

[HACKERS] Improvement of versioning on Windows, take two

2014-07-16 Thread Michael Paquier
Hi all, Please find attached a patch finishing the work begun during CF1. This adds versioning support for all the remaining dll and exe files on both MinGW and MSVC: - regress.dll (MSVC only) - isolationtester.exe - pg_isolation_regress.exe - pg_regress.exe - pg_regress_ecpg.exe - zic.exe I will