Re: [HACKERS] Inconsistency in postgresql.conf

2011-10-10 Thread Bruce Momjian
Bruce Momjian wrote: I notice that we use '(none)' as a default for external_pid_file, while other default no-value settings in the file are ''. The attached patch changes this. Applied. -- Bruce Momjian br...@momjian.ushttp://momjian.us EnterpriseDB

[HACKERS] Inconsistency in postgresql.conf

2011-10-01 Thread Bruce Momjian
I notice that we use '(none)' as a default for external_pid_file, while other default no-value settings in the file are ''. The attached patch changes this. -- Bruce Momjian br...@momjian.ushttp://momjian.us EnterpriseDB http://enterprisedb.com + It's

Re: [HACKERS] Inconsistency between postgresql.conf and docs

2011-07-07 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: On Thu, Jun 30, 2011 at 1:34 AM, Josh Berkus j...@agliodbs.com wrote: My preference would be to have: # REPLICATION # - Master Settings - # these settings affect the master role in replication # they will be ignored on the standby ... settings

Re: [HACKERS] Inconsistency between postgresql.conf and docs

2011-07-07 Thread Robert Haas
On Thu, Jul 7, 2011 at 1:26 PM, Tom Lane t...@sss.pgh.pa.us wrote: Fujii Masao masao.fu...@gmail.com writes: On Thu, Jun 30, 2011 at 1:34 AM, Josh Berkus j...@agliodbs.com wrote: My preference would be to have: # REPLICATION # - Master Settings - # these settings affect the master role in

Re: [HACKERS] Inconsistency between postgresql.conf and docs

2011-07-07 Thread Peter Eisentraut
On tor, 2011-07-07 at 13:26 -0400, Tom Lane wrote: OK, so the plan is to move these settings into a separate top-level group Replication, and sub-divide into master and standby settings, Most of the messages use the term primary rather than master. I think there was a discussion in 9.0 in

Re: [HACKERS] Inconsistency between postgresql.conf and docs

2011-07-07 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On tor, 2011-07-07 at 13:26 -0400, Tom Lane wrote: OK, so the plan is to move these settings into a separate top-level group Replication, and sub-divide into master and standby settings, Most of the messages use the term primary rather than master. I

Re: [HACKERS] Inconsistency between postgresql.conf and docs

2011-07-05 Thread Fujii Masao
On Thu, Jun 30, 2011 at 1:34 AM, Josh Berkus j...@agliodbs.com wrote: My preference would be to have: # REPLICATION # - Master Settings - # these settings affect the master role in replication # they will be ignored on the standby ... settings ... # - Standby Settings - # these

Re: [HACKERS] Inconsistency between postgresql.conf and docs

2011-06-29 Thread Robert Haas
On Tue, Jun 28, 2011 at 11:52 PM, Josh Berkus j...@agliodbs.com wrote: But in the sample file, the synchronous_standby_names parameter is the first parameter under the heading - Streaming Replication - Server Settings while in the documentation, that parameter has its own subsection 18.5.5

Re: [HACKERS] Inconsistency between postgresql.conf and docs

2011-06-29 Thread Josh Berkus
I don't have a strong feeling on whether or not we should put that setting in its own section. Right now, we only have one setting for synchronous replication, so I guess maybe it depends on if we think there will be more in the future. I believe there will be more in the future. However,

[HACKERS] Inconsistency between postgresql.conf and docs

2011-06-28 Thread Josh Berkus
All, A tester correctly reported this: But in the sample file, the synchronous_standby_names parameter is the first parameter under the heading - Streaming Replication - Server Settings while in the documentation, that parameter has its own subsection 18.5.5 after the streaming