Re: [HACKERS] Incorrect comment of XLByteToSeg() and XLByteToPrevSeg()

2017-08-01 Thread Yugo Nagata
On Tue, 01 Aug 2017 08:11:23 +0900 (JST) Tatsuo Ishii wrote: > > Thanks for the patch. Looks good to me. I will commit/push into all > > supported branches if there's no objection. > > Done. Thanks! > > Best regards, > -- > Tatsuo Ishii > SRA OSS, Inc. Japan > English: http://www.sraoss.co.jp/

Re: [HACKERS] Incorrect comment of XLByteToSeg() and XLByteToPrevSeg()

2017-07-31 Thread Tatsuo Ishii
> Thanks for the patch. Looks good to me. I will commit/push into all > supported branches if there's no objection. Done. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp -- Sent via pgsql-hackers mailing list (pgs

Re: [HACKERS] Incorrect comment of XLByteToSeg() and XLByteToPrevSeg()

2017-07-27 Thread Tatsuo Ishii
> I found a type in the comment for XLByteToSeg() and XLByteToPrevSeg(). > This says "Compute ID and segment from an XLogRecPtr", but these > macros compute only segment numbers. I think "Compute a segment number > from an XLogRecPtr" is correct. > > The definition of these macros were modified by

[HACKERS] Incorrect comment of XLByteToSeg() and XLByteToPrevSeg()

2017-07-20 Thread Yugo Nagata
Hi, I found a type in the comment for XLByteToSeg() and XLByteToPrevSeg(). This says "Compute ID and segment from an XLogRecPtr", but these macros compute only segment numbers. I think "Compute a segment number from an XLogRecPtr" is correct. The definition of these macros were modified by the fo