Re: [HACKERS] Indirect assignment code for array slices is dead code?

2017-03-10 Thread Andres Freund
Hi, On 2017-03-10 20:59:48 -0500, Tom Lane wrote: > Andres Freund writes: > > In the context of my expression evaluation patch, I was trying to > > increase test coverage of execQual.c. I'm a bit confused about > > $subject. ExecEvalArrayRef() has the following codepath: > > I think it may ind

Re: [HACKERS] Indirect assignment code for array slices is dead code?

2017-03-10 Thread Tom Lane
Andres Freund writes: > In the context of my expression evaluation patch, I was trying to > increase test coverage of execQual.c. I'm a bit confused about > $subject. ExecEvalArrayRef() has the following codepath: I think it may indeed be unreachable at present, because we don't support somethi

[HACKERS] Indirect assignment code for array slices is dead code?

2017-03-10 Thread Andres Freund
Hi, In the context of my expression evaluation patch, I was trying to increase test coverage of execQual.c. I'm a bit confused about $subject. ExecEvalArrayRef() has the following codepath: if (isAssignment) { Datum sourceData; Datum save_datum; bool