Re: [HACKERS] Is autovacuum too noisy about orphan temp tables?

2008-10-15 Thread Decibel!
On Oct 14, 2008, at 4:04 PM, Alvaro Herrera wrote: Tom Lane wrote: ITAGAKI Takahiro [EMAIL PROTECTED] writes: Standard DBAs are blind to LOG level messages. Indeed, which is why I'm not too concerned about Heikki's complaint. Well, if the disk fills up due to excessive LOG entries, they

Re: [HACKERS] Is autovacuum too noisy about orphan temp tables?

2008-10-15 Thread Tom Lane
Decibel! [EMAIL PROTECTED] writes: Since this is something that's not supposed to happen, making it a WARNING might be appropriate too... Uh, the complaint was that the message is too noisy, not that it isn't noisy enough. regards, tom lane -- Sent via pgsql-hackers

Re: [HACKERS] Is autovacuum too noisy about orphan temp tables?

2008-10-15 Thread Robert Haas
On Wed, Oct 15, 2008 at 11:29 AM, Tom Lane [EMAIL PROTECTED] wrote: Decibel! [EMAIL PROTECTED] writes: Since this is something that's not supposed to happen, making it a WARNING might be appropriate too... Uh, the complaint was that the message is too noisy, not that it isn't noisy enough.

Re: [HACKERS] Is autovacuum too noisy about orphan temp tables?

2008-10-15 Thread Tom Lane
Robert Haas [EMAIL PROTECTED] writes: A much better solution would be to not print the warning every time. I think the right solution is to do exactly what you rejected upthread, namely adding some kind of stack to track the last time this was printed. I really doubt that the problem is worth

Re: [HACKERS] Is autovacuum too noisy about orphan temp tables?

2008-10-15 Thread Greg Stark
Can autovacuum just set a flag on the orphaned temp table's pg_class record indicating it's been determined to be an orphan? Then other tools could easily list orphaned tables and offer to delete them. greg On 15 Oct 2008, at 10:52 PM, Tom Lane [EMAIL PROTECTED] wrote: Robert Haas [EMAIL

Re: [HACKERS] Is autovacuum too noisy about orphan temp tables?

2008-10-15 Thread Alvaro Herrera
Greg Stark escribió: Can autovacuum just set a flag on the orphaned temp table's pg_class record indicating it's been determined to be an orphan? Then other tools could easily list orphaned tables and offer to delete them. Add a new column to pg_class just for orphan tables? Sure sounds

Re: [HACKERS] Is autovacuum too noisy about orphan temp tables?

2008-10-14 Thread ITAGAKI Takahiro
Tom Lane [EMAIL PROTECTED] wrote: Heikki Linnakangas [EMAIL PROTECTED] writes: LOG: autovacuum: found orphan temp table pg_temp_2.foo in database postgres What else would you do? I can't see adding state to remember when we printed it last. Why can't we drop orphan temp tables

Re: [HACKERS] Is autovacuum too noisy about orphan temp tables?

2008-10-14 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: LOG: autovacuum: found orphan temp table pg_temp_2.foo in database postgres I remember the discussion when that was put in, but I'm starting to think that printing that every time autovacuum wakes up, which is once per minute by default, is

[HACKERS] Is autovacuum too noisy about orphan temp tables?

2008-10-14 Thread Heikki Linnakangas
While playing around, I got into the situation that I have an orphaned temp table in my database. The log is now slowly filling with these messages: LOG: autovacuum: found orphan temp table pg_temp_2.foo in database postgres LOG: autovacuum: found orphan temp table pg_temp_2.foo in database

Re: [HACKERS] Is autovacuum too noisy about orphan temp tables?

2008-10-14 Thread Tom Lane
ITAGAKI Takahiro [EMAIL PROTECTED] writes: Why can't we drop orphan temp tables automatically? See prior discussion --- it was deemed too risky. What if there's a bug in the determination of what's an orphan temp table? Standard DBAs are blind to LOG level messages. Indeed, which is why I'm

Re: [HACKERS] Is autovacuum too noisy about orphan temp tables?

2008-10-14 Thread Alvaro Herrera
Tom Lane wrote: ITAGAKI Takahiro [EMAIL PROTECTED] writes: Standard DBAs are blind to LOG level messages. Indeed, which is why I'm not too concerned about Heikki's complaint. Well, if the disk fills up due to excessive LOG entries, they won't be so blind. I think just adding the HINT is