Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-09-21 Thread Amit Kapila
On Fri, Sep 20, 2013 at 7:17 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Sep 20, 2013 at 9:43 AM, Amit Kapila amit.kapil...@gmail.com wrote: Handling for OID is not clear, shall we allow it or not in check constraint? In my current patch OID will not be allowed in check

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-09-20 Thread Amit Kapila
On Thu, Sep 19, 2013 at 10:28 PM, Robert Haas robertmh...@gmail.com wrote: Marking this as Ready for committer. Thanks a ton for reviewing the patch. I rewrote the comments for this patch and fixed the incorrect formatting in parse_relation.c. It used spaces instead of tabs, which is why

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-09-20 Thread Amit Kapila
On Fri, Sep 20, 2013 at 12:57 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Thu, Sep 19, 2013 at 10:28 PM, Robert Haas robertmh...@gmail.com wrote: Marking this as Ready for committer. Thanks a ton for reviewing the patch. I rewrote the comments for this patch and fixed the incorrect

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-09-20 Thread Robert Haas
On Fri, Sep 20, 2013 at 3:41 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Fri, Sep 20, 2013 at 12:57 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Thu, Sep 19, 2013 at 10:28 PM, Robert Haas robertmh...@gmail.com wrote: Marking this as Ready for committer. Thanks a ton for reviewing

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-09-20 Thread Amit Kapila
On Fri, Sep 20, 2013 at 5:53 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Sep 20, 2013 at 3:41 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Fri, Sep 20, 2013 at 12:57 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Thu, Sep 19, 2013 at 10:28 PM, Robert Haas

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-09-20 Thread Robert Haas
On Fri, Sep 20, 2013 at 9:43 AM, Amit Kapila amit.kapil...@gmail.com wrote: Handling for OID is not clear, shall we allow it or not in check constraint? In my current patch OID will not be allowed in check constraint. I vote for allowing it. -- Robert Haas EnterpriseDB:

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-09-20 Thread Amit Kapila
On Fri, Sep 20, 2013 at 7:17 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Sep 20, 2013 at 9:43 AM, Amit Kapila amit.kapil...@gmail.com wrote: Handling for OID is not clear, shall we allow it or not in check constraint? In my current patch OID will not be allowed in check

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-09-19 Thread Robert Haas
Marking this as Ready for committer. Thanks a ton for reviewing the patch. I rewrote the comments for this patch and fixed the incorrect formatting in parse_relation.c. It used spaces instead of tabs, which is why if you look at the patch file you'll see that the alignment looked off. See

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-09-17 Thread Rushabh Lathia
Hi Amit. I gone through the mail thread discussion regarding this issue and reviewed you patch. -- Patch get applied cleanly on Master branch -- Make and Make Install fine -- make check also running cleanly In the patch code changes looks good to me. This patch having two part: 1) Allowed

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-09-17 Thread Amit Kapila
On Tue, Sep 17, 2013 at 3:29 PM, Rushabh Lathia rushabh.lat...@gmail.com wrote: Hi Amit. I gone through the mail thread discussion regarding this issue and reviewed you patch. -- Patch get applied cleanly on Master branch -- Make and Make Install fine -- make check also running cleanly

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-09-15 Thread Amit Kapila
Bruce Momjian wrote: On Sun, Jun 30, 2013 at 06:57:10AM +, Amit kapila wrote: I have done the initial analysis and prepared a patch, don't know if anything more I can do until someone can give any suggestions to further proceed on this bug. So, I guess we never figured this out. I

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-07-01 Thread 'Bruce Momjian'
On Sun, Jun 30, 2013 at 06:57:10AM +, Amit kapila wrote: I have done the initial analysis and prepared a patch, don't know if anything more I can do until someone can give any suggestions to further proceed on this bug. So, I guess we never figured this out. I can submit this

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-06-30 Thread Amit kapila
On Saturday, June 29, 2013 4:58 AM Bruce Momjian wrote: On Sat, Jan 26, 2013 at 11:31:49AM +0530, Amit Kapila wrote: On Friday, January 25, 2013 8:36 PM Bruce Momjian wrote: On Fri, Sep 14, 2012 at 02:04:51PM +, Amit kapila wrote: On Thu, 6 Sep 2012 14:50:05 -0400 Robert Hass wrote:

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-06-28 Thread 'Bruce Momjian'
On Sat, Jan 26, 2013 at 11:31:49AM +0530, Amit Kapila wrote: On Friday, January 25, 2013 8:36 PM Bruce Momjian wrote: On Fri, Sep 14, 2012 at 02:04:51PM +, Amit kapila wrote: On Thu, 6 Sep 2012 14:50:05 -0400 Robert Hass wrote: On Tue, Aug 28, 2012 at 6:40 AM, Amit Kapila

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-01-25 Thread Bruce Momjian
On Fri, Sep 14, 2012 at 02:04:51PM +, Amit kapila wrote: On Thu, 6 Sep 2012 14:50:05 -0400 Robert Hass wrote: On Tue, Aug 28, 2012 at 6:40 AM, Amit Kapila amit(dot)kapila(at)huawei(dot) com wrote: AFAICT during Update also, it doesn't contain useful. The only chance it would have

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2013-01-25 Thread Amit Kapila
On Friday, January 25, 2013 8:36 PM Bruce Momjian wrote: On Fri, Sep 14, 2012 at 02:04:51PM +, Amit kapila wrote: On Thu, 6 Sep 2012 14:50:05 -0400 Robert Hass wrote: On Tue, Aug 28, 2012 at 6:40 AM, Amit Kapila amit(dot)kapila(at)huawei(dot) com wrote: AFAICT during Update

FW: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2012-09-15 Thread Amit kapila
, 2012 7:34 PM To: robertmh...@gmail.com Cc: t...@sss.pgh.pa.us; pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior On Thu, 6 Sep 2012 14:50:05 -0400 Robert Hass wrote: On Tue, Aug 28, 2012 at 6:40 AM, Amit Kapila amit(dot)kapila(at)huawei(dot)com

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

2012-09-14 Thread Amit kapila
On Thu, 6 Sep 2012 14:50:05 -0400 Robert Hass wrote: On Tue, Aug 28, 2012 at 6:40 AM, Amit Kapila amit(dot)kapila(at)huawei(dot)com wrote: AFAICT during Update also, it doesn't contain useful. The only chance it would have contain something useful is when it goes for EvalPlanQual and then