On 6/20/17 05:50, Etsuro Fujita wrote:
> Here is a small patch to add a comment on its new member PartitionRoot.
The existing comment style is kind of unusual. How about the attached
to clean it up a bit?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From 07c05624689a3b1762a2816aeb2c70072b2382d0 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Tue, 20 Jun 2017 14:29:48 -0400
Subject: [PATCH] Reformat comments about ResultRelInfo
---
src/include/nodes/execnodes.h | 80 +++
1 file changed, 50 insertions(+), 30 deletions(-)
diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h
index 9c0852853a..7e214deafd 100644
--- a/src/include/nodes/execnodes.h
+++ b/src/include/nodes/execnodes.h
@@ -336,61 +336,81 @@ typedef struct JunkFilter
AttrNumber jf_junkAttNo;
} JunkFilter;
-/*
- * ResultRelInfo information
- *
- * Whenever we update an existing relation, we have to
- * update indices on the relation, and perhaps also fire triggers.
- * The ResultRelInfo class is used to hold all the information
needed
- * about a result relation, including indices.. -cim 10/15/89
- *
- * RangeTableIndex result relation's range table
index
- * RelationDescrelation descriptor for result
relation
- * NumIndices # of indices existing
on result relation
- * IndexRelationDescs array of relation descriptors
for indices
- * IndexRelationInfo array of key/attr info for
indices
- * TrigDesctriggers to be fired,
if any
- * TrigFunctions cached lookup info for trigger
functions
- * TrigWhenExprs array of trigger WHEN expr
states
- * TrigInstrument optional runtime measurements
for triggers
- * FdwRoutine FDW callback functions,
if foreign table
- * FdwStateavailable to save
private state of FDW
- * usesFdwDirectModify true when modifying foreign
table directly
- * WithCheckOptionslist of WithCheckOption's to be
checked
- * WithCheckOptionExprslist of WithCheckOption expr states
- * ConstraintExprs array of constraint-checking
expr states
- * junkFilter for removing junk
attributes from tuples
- * projectReturningfor computing a RETURNING list
- * onConflictSetProj for computing ON CONFLICT DO
UPDATE SET
- * onConflictSetWhere list of ON CONFLICT DO UPDATE
exprs (qual)
- * PartitionCheck partition check expression
- * PartitionCheckExpr partition check expression state
- *
+/*
+ * ResultRelInfo
+ *
+ * Whenever we update an existing relation, we have to update indexes on the
+ * relation, and perhaps also fire triggers. ResultRelInfo holds all the
+ * information needed about a result relation, including indexes.
*/
typedef struct ResultRelInfo
{
NodeTag type;
+
+ /* result relation's range table index */
Index ri_RangeTableIndex;
+
+ /* relation descriptor for result relation */
Relationri_RelationDesc;
+
+ /* # of indices existing on result relation */
int ri_NumIndices;
+
+ /* array of relation descriptors for indices */
RelationPtr ri_IndexRelationDescs;
+
+ /* array of key/attr info for indices */
IndexInfo **ri_IndexRelationInfo;
+
+ /* triggers to be fired, if any */
TriggerDesc *ri_TrigDesc;
+
+ /* cached lookup info for trigger functions */
FmgrInfo *ri_TrigFunctions;
+
+ /* array of trigger WHEN expr states */
ExprState **ri_TrigWhenExprs;
+
+ /* optional runtime measurements for triggers */
Instrumentation *ri_TrigInstrument;
+
+ /* FDW callback functions, if foreign table */
struct FdwRoutine *ri_FdwRoutine;
+
+ /* available to save private state of FDW */
void *ri_FdwState;
+
+ /* true when modifying foreign table directly */
boolri_usesFdwDirectModify;
+
+ /* list of WithCheckOption's to be checked */
List *ri_WithCheckOptions;
+
+ /* list of WithCheckOption expr states */
List *ri_WithCheckOptionExprs;
+
+ /* array of constraint-checking expr states */
ExprState **ri_ConstraintExprs;
+
+ /* for removing junk attributes from
