Re: [HACKERS] Missing markup in pg_receivexlog.sgml

2015-02-03 Thread Heikki Linnakangas

On 02/03/2015 10:27 AM, Michael Paquier wrote:

On Tue, Feb 3, 2015 at 4:25 PM, Heikki Linnakangas
 wrote:

Flush the WAL data to disk immediately after it's being received. Also send
a status packet back to the server immediately after flushing, regardless of
--status-interval

Yes, that's indeed better. As long as I am on it, attached is a patch
for that...


Ok, thanks :-). Applied.

- Heikki



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Missing markup in pg_receivexlog.sgml

2015-02-03 Thread Michael Paquier
On Tue, Feb 3, 2015 at 4:25 PM, Heikki Linnakangas
 wrote:
> Flush the WAL data to disk immediately after it's being received. Also send
> a status packet back to the server immediately after flushing, regardless of
> --status-interval
Yes, that's indeed better. As long as I am on it, attached is a patch
for that...
-- 
Michael
diff --git a/doc/src/sgml/ref/pg_receivexlog.sgml b/doc/src/sgml/ref/pg_receivexlog.sgml
index be321b5..0c99744 100644
--- a/doc/src/sgml/ref/pg_receivexlog.sgml
+++ b/doc/src/sgml/ref/pg_receivexlog.sgml
@@ -139,9 +139,9 @@ PostgreSQL documentation
   --synchronous
   

-Issue sync commands as soon as there is WAL data which has not been
-flushed yet. Also status packets are sent back to the server just after
-WAL data is flushed whatever --status-interval is set to.
+Flush the WAL data to disk immediately after it has been received. Also
+send a status packet back to the server immediately after flushing,
+regardless of --status-interval.

   
  

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Missing markup in pg_receivexlog.sgml

2015-02-02 Thread Heikki Linnakangas

On 02/03/2015 05:59 AM, Michael Paquier wrote:

Hi all,

Per $subject, I noticed that a markup was missing in the description
of the option --synchronous.



+Issue sync commands as soon as there is WAL data which has
+not been flushed yet. Also status packets are sent back to the server
+just after WAL data is flushed whatever --status-interval
+is set to.


Hmm. That would imply that pg_receivexlog calls /bin/sync. "sync 
command" was confusing before, but putting it in  tags makes it 
even more so.


I think that should be rewritten:

Flush the WAL data to disk immediately after it's being received. Also 
send a status packet back to the server immediately after flushing, 
regardless of --status-interval


- Heikki



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] Missing markup in pg_receivexlog.sgml

2015-02-02 Thread Michael Paquier
Hi all,

Per $subject, I noticed that a markup was missing in the description
of the option --synchronous.
Patch is attached.
Regards,
-- 
Michael
diff --git a/doc/src/sgml/ref/pg_receivexlog.sgml b/doc/src/sgml/ref/pg_receivexlog.sgml
index be321b5..9405f0f 100644
--- a/doc/src/sgml/ref/pg_receivexlog.sgml
+++ b/doc/src/sgml/ref/pg_receivexlog.sgml
@@ -139,9 +139,10 @@ PostgreSQL documentation
   --synchronous
   

-Issue sync commands as soon as there is WAL data which has not been
-flushed yet. Also status packets are sent back to the server just after
-WAL data is flushed whatever --status-interval is set to.
+Issue sync commands as soon as there is WAL data which has
+not been flushed yet. Also status packets are sent back to the server
+just after WAL data is flushed whatever --status-interval
+is set to.

   
  

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers