Re: [HACKERS] My review for the patch Table command

2008-11-06 Thread Josh Berkus

Unicron,

   4. Since it is just an alternative to select * from Table,  I think 
this feature is

   unneccessary.


Heh.  I agree, but tell that to the SQL committee.

I don't think we need to argue out the merits of adding standard syntax.

This patch is Ready for Code Review.

--Josh

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] My review for the patch Table command

2008-11-06 Thread Tom Lane
Josh Berkus [EMAIL PROTECTED] writes:
 Unicron,
 4. Since it is just an alternative to select * from Table,  I think 
 this feature is unneccessary.

 Heh.  I agree, but tell that to the SQL committee.

 I don't think we need to argue out the merits of adding standard syntax.

We can, however, argue the merits of making extensive documentation
changes to document such a useless feature.

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] My review for the patch Table command

2008-11-05 Thread Unicron
Hi
   I have completed the review for Patch Table command, Here is results
   1. The patch actually implements that.
   2. The feature work as advertised.
   3. So far, I have not found any possible dangers that can be caused by this 
pacth
   4. Since it is just an alternative to select * from Table,  I think this 
feature is 
   unneccessary.

                                                                  Unicron