Re: [HACKERS] Not *quite* there on ecpg fixes

2007-10-05 Thread Michael Meskes
On Thu, Oct 04, 2007 at 02:12:14PM -0400, Tom Lane wrote: I see that libpq manufactures three different .def files, whereas the ecpg code is only making two. Is this OK or an oversight? I'm not Not knowing what the third one is for I deliberately created only two. If there is a reason for

Re: [HACKERS] Not *quite* there on ecpg fixes

2007-10-04 Thread Michael Meskes
On Thu, Oct 04, 2007 at 12:47:13AM -0400, Tom Lane wrote: Buildfarm member brown_bat (cygwin/gcc) still isn't happy: ... Just committed a patch that hopefully solves this. Kind of surprises me that this only occurs on cygwin. Michael -- Michael Meskes Email: Michael at Fam-Meskes dot De,

Re: [HACKERS] Not *quite* there on ecpg fixes

2007-10-04 Thread Andrew Dunstan
Michael Meskes wrote: On Thu, Oct 04, 2007 at 12:47:13AM -0400, Tom Lane wrote: Buildfarm member brown_bat (cygwin/gcc) still isn't happy: ... Just committed a patch that hopefully solves this. Kind of surprises me that this only occurs on cygwin. It's still not working.

Re: [HACKERS] Not *quite* there on ecpg fixes

2007-10-04 Thread Alvaro Herrera
Andrew Dunstan wrote: Michael Meskes wrote: On Thu, Oct 04, 2007 at 12:47:13AM -0400, Tom Lane wrote: Buildfarm member brown_bat (cygwin/gcc) still isn't happy: ... Just committed a patch that hopefully solves this. Kind of surprises me that this only occurs on cygwin. It's

Re: [HACKERS] Not *quite* there on ecpg fixes

2007-10-04 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: It's still not working. Don't have time right now to diagnose why. For now, since Michael doesn't have a windows machine to play with, I have switched brown_bat's schedule so it runs HEAD 6 times a day (not exactly every 4 hours, the intervals vary

Re: [HACKERS] Not *quite* there on ecpg fixes

2007-10-04 Thread Michael Meskes
On Thu, Oct 04, 2007 at 10:04:41AM -0400, Alvaro Herrera wrote: It looks like dlltool does not like the .def file: ... Line 3 of that file is unadorned EXPORTS: echo '; DEF file for MS VC++' libpgtypesdll.def echo 'LIBRARY LIBPGTYPES' libpgtypesdll.def echo 'EXPORTS' libpgtypesdll.def

Re: [HACKERS] Not *quite* there on ecpg fixes

2007-10-04 Thread Alvaro Herrera
Michael Meskes wrote: On Thu, Oct 04, 2007 at 10:04:41AM -0400, Alvaro Herrera wrote: It looks like dlltool does not like the .def file: ... Line 3 of that file is unadorned EXPORTS: echo '; DEF file for MS VC++' libpgtypesdll.def echo 'LIBRARY LIBPGTYPES' libpgtypesdll.def echo

Re: [HACKERS] Not *quite* there on ecpg fixes

2007-10-04 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: Michael Meskes wrote: These lines are simply copied from libpq/Makefile but ddltool does not complain while working on libpq. Any idea where they differ? Newline style perhaps? There seems to be a blank line at the end of

Re: [HACKERS] Not *quite* there on ecpg fixes

2007-10-04 Thread Alvaro Herrera
Michael Meskes wrote: On Thu, Oct 04, 2007 at 10:04:41AM -0400, Alvaro Herrera wrote: It looks like dlltool does not like the .def file: ... Line 3 of that file is unadorned EXPORTS: echo '; DEF file for MS VC++' libpgtypesdll.def echo 'LIBRARY LIBPGTYPES' libpgtypesdll.def echo

Re: [HACKERS] Not *quite* there on ecpg fixes

2007-10-04 Thread Kris Jurka
On Thu, 4 Oct 2007, Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: It's still not working. Don't have time right now to diagnose why. For now, since Michael doesn't have a windows machine to play with, I have switched brown_bat's schedule so it runs HEAD 6 times a day (not

Re: [HACKERS] Not *quite* there on ecpg fixes

2007-10-04 Thread Andrew Dunstan
Michael Meskes wrote: On Thu, Oct 04, 2007 at 10:04:41AM -0400, Alvaro Herrera wrote: It looks like dlltool does not like the .def file: ... Line 3 of that file is unadorned EXPORTS: echo '; DEF file for MS VC++' libpgtypesdll.def echo 'LIBRARY LIBPGTYPES' libpgtypesdll.def echo

Re: [HACKERS] Not *quite* there on ecpg fixes

2007-10-04 Thread Michael Meskes
On Thu, Oct 04, 2007 at 12:35:29PM -0400, Alvaro Herrera wrote: The libpq exports.txt has spaces, not tabs, as separators. In fact, if you see the .def files you notice that the generated files for ecpg are all wrong. Right, that's it. Simplest is to change tabs to spaces ... However I'm

Re: [HACKERS] Not *quite* there on ecpg fixes

2007-10-04 Thread Tom Lane
Michael Meskes [EMAIL PROTECTED] writes: On Thu, Oct 04, 2007 at 12:35:29PM -0400, Alvaro Herrera wrote: The libpq exports.txt has spaces, not tabs, as separators. In fact, if you see the .def files you notice that the generated files for ecpg are all wrong. Right, that's it. I see that

Re: [HACKERS] Not *quite* there on ecpg fixes

2007-10-04 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: One thing I noticed is this: ifneq ($(PORTNAME), win32) OBJS += thread.o DLL_DEFFILE=libecpgdll.def endif Why are we defining DLL_DEFFILE for the non-win32 case but not for the win32 case? Comparing to the libpq Makefile, this seems definitely

[HACKERS] Not *quite* there on ecpg fixes

2007-10-03 Thread Tom Lane
Buildfarm member brown_bat (cygwin/gcc) still isn't happy: gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -g -I../include -I../../../../src/interfaces/ecpg/include -I../../../../src/include/utils