Chuck McDevitt wrote:
What if the block of text is split in the middle of a multibyte character?
I don't think it is safe to assume raw blocks always end on a character
boundary.
Yeah, it's not. I realized myself after submitting. The generic approach
is to loop with pg_mblen() to find out
Robert Haas wrote:
Heikki,
I was assigned as a round-robin reviewer for this patch, but it looks
to me like it is still WIP, so I'm not sure how much effort it's worth
putting in at this point. Do you plan to finish this for 8.4, and if
so, should I wait for the next version before reviewing
What if the block of text is split in the middle of a multibyte character?
I don't think it is safe to assume raw blocks always end on a character
boundary.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
Heikki Linnakangas [EMAIL PROTECTED] writes:
I'd really like to work on this to get it into 8.4, but being honest to
myself, I don't think I have the time to finish and benchmark it. I'm
swamped with reviewing other's patches, as well as with non-PG-related
work. I have some work to do on
Heikki,
I was assigned as a round-robin reviewer for this patch, but it looks
to me like it is still WIP, so I'm not sure how much effort it's worth
putting in at this point. Do you plan to finish this for 8.4, and if
so, should I wait for the next version before reviewing further?
Thanks,
Back in March, I played around with various hacks to improve COPY FROM
performance:
http://archives.postgresql.org/pgsql-patches/2008-03/msg00145.php
I got busy with other stuff, but I now got around to try what I planned
back then. I don't know if I have the time to finish this for 8.4, but
Heikki Linnakangas [EMAIL PROTECTED] writes:
The basic idea is to replace the custom loop in CopyReadLineText with
memchr(), because memchr() is very fast. To make that possible, perform
the client-server encoding conversion on each raw block that we read in,
before splitting it into lines.
