Re: [HACKERS] Partitioning performance: cache stringToNode() of pg_constraint.ccbin

2014-08-10 Thread Noah Misch
On Thu, Aug 07, 2014 at 09:39:57AM -0400, Robert Haas wrote: On Wed, Aug 6, 2014 at 9:35 PM, Bruce Momjian br...@momjian.us wrote: On Sun, Jan 12, 2014 at 12:53:40PM -0500, Noah Misch wrote: Further study revealed a defect in the patch's memory management, and I have not gotten around to

Re: [HACKERS] Partitioning performance: cache stringToNode() of pg_constraint.ccbin

2014-08-07 Thread Robert Haas
On Wed, Aug 6, 2014 at 9:35 PM, Bruce Momjian br...@momjian.us wrote: On Sun, Jan 12, 2014 at 12:53:40PM -0500, Noah Misch wrote: On Sat, Jan 11, 2014 at 02:10:01PM -0500, Bruce Momjian wrote: On Mon, Jun 3, 2013 at 03:07:27PM -0400, Noah Misch wrote: A colleague, Korry Douglas, observed a

Re: [HACKERS] Partitioning performance: cache stringToNode() of pg_constraint.ccbin

2014-08-06 Thread Bruce Momjian
On Sun, Jan 12, 2014 at 12:53:40PM -0500, Noah Misch wrote: On Sat, Jan 11, 2014 at 02:10:01PM -0500, Bruce Momjian wrote: On Mon, Jun 3, 2013 at 03:07:27PM -0400, Noah Misch wrote: A colleague, Korry Douglas, observed a table partitioning scenario where deserializing pg_constraint.ccbin

Re: [HACKERS] Partitioning performance: cache stringToNode() of pg_constraint.ccbin

2014-01-12 Thread Noah Misch
On Sat, Jan 11, 2014 at 02:10:01PM -0500, Bruce Momjian wrote: On Mon, Jun 3, 2013 at 03:07:27PM -0400, Noah Misch wrote: A colleague, Korry Douglas, observed a table partitioning scenario where deserializing pg_constraint.ccbin is a hot spot. The following test case, a simplification of

Re: [HACKERS] Partitioning performance: cache stringToNode() of pg_constraint.ccbin

2014-01-11 Thread Bruce Momjian
On Mon, Jun 3, 2013 at 03:07:27PM -0400, Noah Misch wrote: A colleague, Korry Douglas, observed a table partitioning scenario where deserializing pg_constraint.ccbin is a hot spot. The following test case, a simplification of a typical partitioning setup, spends 28% of its time in

Re: [HACKERS] Partitioning performance: cache stringToNode() of pg_constraint.ccbin

2013-06-07 Thread Amit Kapila
On Friday, June 07, 2013 2:10 AM Noah Misch wrote: On Thu, Jun 06, 2013 at 07:02:27PM +0530, Amit Kapila wrote: On Tuesday, June 04, 2013 12:37 AM Noah Misch wrote: This patch can give good performance gain in the scenario described by you. Infact I had taken the readings with patch, it

Re: [HACKERS] Partitioning performance: cache stringToNode() of pg_constraint.ccbin

2013-06-07 Thread Noah Misch
On Fri, Jun 07, 2013 at 11:58:14AM +0530, Amit Kapila wrote: So the memory increase number's would like: Example for 64-bit m/c In database, there are 100 tables, each having 2 constraints and 30 live connections Size increase = no. of tables * size of (Node*) * number of constraints *

Re: [HACKERS] Partitioning performance: cache stringToNode() of pg_constraint.ccbin

2013-06-06 Thread Amit Kapila
On Tuesday, June 04, 2013 12:37 AM Noah Misch wrote: A colleague, Korry Douglas, observed a table partitioning scenario where deserializing pg_constraint.ccbin is a hot spot. The following test case, a simplification of a typical partitioning setup, spends 28% of its time in stringToNode()

Re: [HACKERS] Partitioning performance: cache stringToNode() of pg_constraint.ccbin

2013-06-06 Thread Noah Misch
On Thu, Jun 06, 2013 at 07:02:27PM +0530, Amit Kapila wrote: On Tuesday, June 04, 2013 12:37 AM Noah Misch wrote: This patch can give good performance gain in the scenario described by you. Infact I had taken the readings with patch, it shows similar gain. Thanks for testing. This patch