Re: [HACKERS] Patch: create or replace language

2009-10-06 Thread Bernd Helmle
--On 6. Oktober 2009 10:13:54 -0400 Tom Lane wrote: http://archives.postgresql.org/pgsql-patches/2008-03/msg00416.php namely that CREATE OR REPLACE should leave the object having the properties specified in the command. Maybe when implementing this, it can be worth to keep an eye on ALTER

Re: [HACKERS] Patch: create or replace language

2009-10-06 Thread Robert Haas
On Tue, Oct 6, 2009 at 10:48 AM, Tom Lane wrote: > Robert Haas writes: >> Maybe I'm out of line to say this, but it seems to me that we should >> not even be looking at newly-submitted patches at this point. > > It would have been more work to put it in the queue to reject later > than to reject

Re: [HACKERS] Patch: create or replace language

2009-10-06 Thread Tom Lane
Robert Haas writes: > Maybe I'm out of line to say this, but it seems to me that we should > not even be looking at newly-submitted patches at this point. It would have been more work to put it in the queue to reject later than to reject it now ;-). Besides, this way Andreas has a chance to rewr

Re: [HACKERS] Patch: create or replace language

2009-10-06 Thread Alvaro Herrera
Robert Haas escribió: > On Tue, Oct 6, 2009 at 10:24 AM, Alvaro Herrera > wrote: > > this comment needs fixed. > > Maybe I'm out of line to say this, but it seems to me that we should > not even be looking at newly-submitted patches at this point. Yeah, it was so short I didn't see any point in

Re: [HACKERS] Patch: create or replace language

2009-10-06 Thread Robert Haas
On Tue, Oct 6, 2009 at 10:24 AM, Alvaro Herrera wrote: > Andreas 'ads' Scherbaum wrote: >> >> Hello, >> >> following this old discussion: >> >> http://archives.postgresql.org/pgsql-patches/2008-03/msg00402.php >> >> i modifies the patch to use the "CREATE [OR REPLACE] LANGUAGE" syntax. >> If the p

Re: [HACKERS] Patch: create or replace language

2009-10-06 Thread Alvaro Herrera
Andreas 'ads' Scherbaum wrote: > > Hello, > > following this old discussion: > > http://archives.postgresql.org/pgsql-patches/2008-03/msg00402.php > > i modifies the patch to use the "CREATE [OR REPLACE] LANGUAGE" syntax. > If the patch is ok, i will add the documentation too. Please send a co

Re: [HACKERS] Patch: create or replace language

2009-10-06 Thread Tom Lane
"Andreas 'ads' Scherbaum" writes: > following this old discussion: > http://archives.postgresql.org/pgsql-patches/2008-03/msg00402.php > i modifies the patch to use the "CREATE [OR REPLACE] LANGUAGE" syntax. This is not an "OR REPLACE" operation, because it doesn't replace the existing definition

[HACKERS] Patch: create or replace language

2009-10-06 Thread Andreas 'ads' Scherbaum
Hello, following this old discussion: http://archives.postgresql.org/pgsql-patches/2008-03/msg00402.php i modifies the patch to use the "CREATE [OR REPLACE] LANGUAGE" syntax. If the patch is ok, i will add the documentation too. Kind regards -- Andreas 'ads'