Re: [HACKERS] Patch for fast gin cache performance improvement

2013-10-12 Thread Ian Link
I think it is desirable that this patch should be resubmitted for the next CommitFest for further review and testing mentioned above. So I'd like to mark this patch as Returned with Feedback. Is it OK? Sounds like a good idea. Thanks for the review! Ian Link Etsuro Fujita

Re: [HACKERS] Patch for fast gin cache performance improvement

2013-10-10 Thread Etsuro Fujita
Ian Link wrote: Although I asked this question, I've reconsidered about these parameters, and it seems that these parameters not only make code rather complex but are a little confusing to users. So I'd like to propose to introduce only one parameter: fast_cache_size. While users that

Re: [HACKERS] Patch for fast gin cache performance improvement

2013-10-08 Thread Ian Link
Although I asked this question, I've reconsidered about these parameters, and it seems that these parameters not only make code rather complex but are a little confusing to users. So I'd like to propose to introduce only one parameter: fast_cache_size. While users that give weight to update

Re: [HACKERS] Patch for fast gin cache performance improvement

2013-09-30 Thread Ian Link
Hi Etsuro, Sorry for the delay but I have been very busy with work. I have been away from postgres for a while, so I will need a little time to review the code and make sure I give you an informed response. I'll get back to you as soon as I am able. Thanks for understanding. Ian Link

Re: [HACKERS] Patch for fast gin cache performance improvement

2013-09-27 Thread Etsuro Fujita
I wrote: I had a look over this patch. I think this patch is interesting and very useful. Here are my review points: 8. I think there are no issues in this patch. However, I have one question: how this patch works in the case where gin_fast_limit/fast_cache_size = 0? In this case, in my

Re: [HACKERS] Patch for fast gin cache performance improvement

2013-09-26 Thread Etsuro Fujita
Hi Ian, This patch contains a performance improvement for the fast gin cache. As you may know, the performance of the fast gin cache decreases with its size. Currently, the size of the fast gin cache is tied to work_mem. The size of work_mem can often be quite high. The large size of work_mem

Re: [HACKERS] Patch for fast gin cache performance improvement

2013-06-23 Thread Stefan Kaltenbrunner
On 06/23/2013 04:03 AM, ian link wrote: Looks like my community login is still not working. No rush, just wanted to let you know. Thanks! have you tried to log in once to the main website per:

Re: [HACKERS] Patch for fast gin cache performance improvement

2013-06-23 Thread Ian Link
I just tried it and my account works now. Thanks! Ian Stefan Kaltenbrunner Sunday, June 23, 2013 2:05 AM have you tried to log in once to the main website per:http://www.postgresql.org/message-id/CABUevEyt9tQfcF7T2Uzcr8WeF9M=s8qSACuCmN5L2Et26=r...@mail.gmail.com?Stefan

Re: [HACKERS] Patch for fast gin cache performance improvement

2013-06-22 Thread ian link
Looks like my community login is still not working. No rush, just wanted to let you know. Thanks! Ian On Tue, Jun 18, 2013 at 11:41 AM, Ian Link i...@ilink.io wrote: No worries! I'll just wait until it's up again. Thanks Ian Kevin Grittner kgri...@ymail.com Tuesday, June 18, 2013

Re: [HACKERS] Patch for fast gin cache performance improvement

2013-06-18 Thread Kevin Grittner
Ian Link i...@ilink.io wrote: This patch contains a performance improvement for the fast gin cache. Our test queries improve from about 0.9 ms to 0.030 ms. Impressive! Thanks for reading and considering this patch! Congratulations on your first PostgreSQL patch!  To get it scheduled for

Re: [HACKERS] Patch for fast gin cache performance improvement

2013-06-18 Thread Kevin Grittner
Kevin Grittner kgri...@ymail.com wrote: You will need to get a community login (if you don't already have one), but that is a quick and painless process. Oops -- we seem to have a problem with new community logins at the moment, which will hopefully be straightened out soon.  You might want to

Re: [HACKERS] Patch for fast gin cache performance improvement

2013-06-18 Thread Ian Link
No worries! I'll just wait until it's up again. Thanks Ian Kevin Grittner Tuesday, June 18, 2013 9:15 AM Oops -- we seem to have a problem with new community logins at themoment, which will hopefully be straightened out soon. You mightwant to wait a few days if you