Re: [HACKERS] Policy on pulling in code from other projects?

2011-08-10 Thread David E. Wheeler
On Aug 9, 2011, at 6:00 PM, Peter van Hardenberg wrote: In conclusion, this is a serious operational concern for me and my team and I will be personally dealing with fires caused by this for years to come regardless of the outcome of this thread. Do you have an interest in funding

Re: [HACKERS] Policy on pulling in code from other projects?

2011-08-09 Thread Peter van Hardenberg
On Sat, Jul 23, 2011 at 3:39 AM, Andrew Dunstan and...@dunslane.net wrote: 1. I think the proposed use is of very marginal value at best, and certainly not worth importing an external library for. Now that I've seen two people who seem to think that this is not an important feature I'll wade

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-25 Thread Robert Haas
On Sun, Jul 24, 2011 at 10:12 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Dave Page's message of sáb jul 23 02:25:30 -0400 2011: Also consider if the library is widely available on common distros or not. If not, packagers are going to have to start packaging that first,

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-25 Thread Dave Page
On Mon, Jul 25, 2011 at 3:12 AM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Dave Page's message of sáb jul 23 02:25:30 -0400 2011: Also consider if the library is widely available on common distros or not. If not, packagers are going to have to start packaging that first,

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-24 Thread Alvaro Herrera
Excerpts from Dave Page's message of sáb jul 23 02:25:30 -0400 2011: Also consider if the library is widely available on common distros or not. If not, packagers are going to have to start packaging that first, in order to build the PostgreSQL packages. This is a *huge* issue for use if we

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-23 Thread Dave Page
On Saturday, July 23, 2011, Christopher Browne cbbro...@gmail.com wrote: I generally agree, Josh, but I think readline is getting pointed at a bit too much.  Yeah, it's a bad one, but we also include other stuff like zlib that doesn't commonly come up as an issue. I'd argue something just a

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-23 Thread Andrew Dunstan
On 07/22/2011 10:51 AM, Joshua D. Drake wrote: On 07/21/2011 11:13 AM, Tom Lane wrote: Joshua D. Drakej...@commandprompt.com writes: So I am looking intently on what it is going to take to get the URI patch done for psql [1] and was digging around the web and have a URI parser library. It

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-23 Thread Joshua D. Drake
On 07/22/2011 05:00 PM, Josh Berkus wrote: Arguments in favor of coding from scratch: 1) Does not introduce new dependencies into postgresql-client packages. (note how much of a problem Readline has been) Readline has license issues, this doesn't. 2) keeps psql as lightweight as possible

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-23 Thread Joshua D. Drake
On 07/23/2011 03:39 AM, Andrew Dunstan wrote: 1. I think the proposed use is of very marginal value at best, and certainly not worth importing an external library for. 2. Even if we have the feature, we do not need to parse URIs generally. A small amount of hand written C code should suffice.

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-22 Thread Joshua D. Drake
On 07/21/2011 11:13 AM, Tom Lane wrote: Joshua D. Drakej...@commandprompt.com writes: So I am looking intently on what it is going to take to get the URI patch done for psql [1] and was digging around the web and have a URI parser library. It is under the New BSD license and is strictly RFC

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-22 Thread Robert Haas
On Fri, Jul 22, 2011 at 10:51 AM, Joshua D. Drake j...@commandprompt.com wrote: On 07/21/2011 11:13 AM, Tom Lane wrote: Joshua D. Drakej...@commandprompt.com  writes: So I am looking intently on what it is going to take to get the URI patch done for psql [1] and was digging around the web

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-22 Thread Joshua D. Drake
On 07/22/2011 08:36 AM, Robert Haas wrote: On Fri, Jul 22, 2011 at 10:51 AM, Joshua D. Drakej...@commandprompt.com wrote: On 07/21/2011 11:13 AM, Tom Lane wrote: Joshua D. Drakej...@commandprompt.comwrites: So I am looking intently on what it is going to take to get the URI patch done

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-22 Thread Robert Haas
On Fri, Jul 22, 2011 at 11:43 AM, Joshua D. Drake j...@commandprompt.com wrote: OP of this thread: http://archives.postgresql.org/pgsql-hackers/2011-07/msg01144.php It is letting pgsql use URI syntax. Sorry, I missed that the first time. IMHO, it seems like it would be simpler to do that

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-22 Thread Joshua D. Drake
On 07/22/2011 09:03 AM, Robert Haas wrote: On Fri, Jul 22, 2011 at 11:43 AM, Joshua D. Drakej...@commandprompt.com wrote: OP of this thread: http://archives.postgresql.org/pgsql-hackers/2011-07/msg01144.php It is letting pgsql use URI syntax. Sorry, I missed that the first time. IMHO, it

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-22 Thread Joshua D. Drake
On 07/22/2011 10:57 AM, Robert Haas wrote: On Fri, Jul 22, 2011 at 1:26 PM, Joshua D. Drakej...@commandprompt.com wrote: IMHO, it seems like it would be simpler to do that by rolling our own code rather than importing someone else's. I mean, look, there is precedent for doing this. We

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-22 Thread Robert Haas
On Fri, Jul 22, 2011 at 2:09 PM, Joshua D. Drake j...@commandprompt.com wrote: I am not neccessarily looking to include it in our tarball. What I asked was: Assuming the code actually makes this patch easier, do we: A. Pull in the code into the main tree B. Instead have it as a requirement

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-22 Thread Kevin Grittner
Joshua D. Drake j...@commandprompt.com wrote: I personally think you are handwaving if you think we can build out a robust parser in a couple of hours. I don't think so. If you have a regular expression engine available, you should be able to get there by picking one of these and modifying:

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-22 Thread Robert Haas
On Fri, Jul 22, 2011 at 2:22 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Joshua D. Drake j...@commandprompt.com wrote: I personally think you are handwaving if you think we can build out a robust parser in a couple of hours. I don't think so.  If you have a regular expression engine

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-22 Thread Peter Eisentraut
On fre, 2011-07-22 at 11:09 -0700, Joshua D. Drake wrote: Assuming the code actually makes this patch easier, do we: A. Pull in the code into the main tree B. Instead have it as a requirement via configure? B -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-22 Thread Greg Smith
On 07/22/2011 02:09 PM, Joshua D. Drake wrote: Remember this library follows the RFC for URIs which is why I even brought it up. If it was just some random parser, I wouldn't even have bothered. Do we care about the RFC for URIs? The main components of the RFC involve: -Decoding escaped

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-22 Thread Josh Berkus
Arguments in favor of coding from scratch: 1) Does not introduce new dependencies into postgresql-client packages. (note how much of a problem Readline has been) 2) keeps psql as lightweight as possible 3) We don't need to be able to parse any potential URI, just the ones we accept. Arguments

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-22 Thread Christopher Browne
I generally agree, Josh, but I think readline is getting pointed at a bit too much. Yeah, it's a bad one, but we also include other stuff like zlib that doesn't commonly come up as an issue. I'd argue something just a wee bit different... By the time we would add in: - autoconf rules to detect

[HACKERS] Policy on pulling in code from other projects?

2011-07-21 Thread Joshua D. Drake
Hey, So I am looking intently on what it is going to take to get the URI patch done for psql [1] and was digging around the web and have a URI parser library. It is under the New BSD license and is strictly RFC RFC 3986 [2] compliant . Now I have not dug into the code but the parser is

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-21 Thread Peter Geoghegan
On 21 July 2011 18:43, Joshua D. Drake j...@commandprompt.com wrote: So I am looking intently on what it is going to take to get the URI patch done for psql [1] and was digging around the web and have a URI parser library. It is under the New BSD license and is strictly RFC  RFC 3986 [2]

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-21 Thread Tom Lane
Joshua D. Drake j...@commandprompt.com writes: So I am looking intently on what it is going to take to get the URI patch done for psql [1] and was digging around the web and have a URI parser library. It is under the New BSD license and is strictly RFC RFC 3986 [2] compliant . Surely we

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-21 Thread Joshua D. Drake
On 07/21/2011 11:13 AM, Tom Lane wrote: Joshua D. Drakej...@commandprompt.com writes: So I am looking intently on what it is going to take to get the URI patch done for psql [1] and was digging around the web and have a URI parser library. It is under the New BSD license and is strictly RFC

Re: [HACKERS] Policy on pulling in code from other projects?

2011-07-21 Thread Joshua D. Drake
On 07/21/2011 11:13 AM, Tom Lane wrote: Joshua D. Drakej...@commandprompt.com writes: So I am looking intently on what it is going to take to get the URI patch done for psql [1] and was digging around the web and have a URI parser library. It is under the New BSD license and is strictly RFC