Re: [HACKERS] Portability issues in TAP tests

2014-10-28 Thread Peter Eisentraut
On 7/21/14 10:06 AM, Christoph Berg wrote: > 6. The tests fail if your $LANG isn't en_something: This was fixed. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Portability issues in TAP tests

2014-10-28 Thread Peter Eisentraut
On 7/17/14 3:31 PM, Tom Lane wrote: > My Salesforce colleagues have been complaining that the TAP tests added > in 9.4 don't work terribly well for them. I've been poking at this, > and I believe this is a reasonably complete list of the problems: Quick followup: > 1. "make [install]check-world"

Re: [HACKERS] Portability issues in TAP tests

2014-07-22 Thread Robert Haas
On Mon, Jul 21, 2014 at 11:39 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 07/21/2014 02:40 PM, Tom Lane wrote: >>> I had the same feeling about the Perl on RHEL6 ;-). The TAP tests >>> will need to be a great deal more portable than they've proven so far >>> before they'll really be usefu

Re: [HACKERS] Portability issues in TAP tests

2014-07-21 Thread Tom Lane
Andrew Dunstan writes: > On 07/21/2014 02:40 PM, Tom Lane wrote: >> I had the same feeling about the Perl on RHEL6 ;-). The TAP tests >> will need to be a great deal more portable than they've proven so far >> before they'll really be useful for anything much. I trust we're >> committed to makin

Re: [HACKERS] Portability issues in TAP tests

2014-07-21 Thread Andrew Dunstan
On 07/21/2014 02:40 PM, Tom Lane wrote: Robert Haas writes: Mmph. Well, I don't want to install a non-default Perl on my system just to make these tests pass, and I don't think that should be a requirement. I had the same feeling about the Perl on RHEL6 ;-). The TAP tests will need to be a

Re: [HACKERS] Portability issues in TAP tests

2014-07-21 Thread Tom Lane
Robert Haas writes: > Mmph. Well, I don't want to install a non-default Perl on my system > just to make these tests pass, and I don't think that should be a > requirement. I had the same feeling about the Perl on RHEL6 ;-). The TAP tests will need to be a great deal more portable than they've

Re: [HACKERS] Portability issues in TAP tests

2014-07-21 Thread Robert Haas
On Mon, Jul 21, 2014 at 12:00 PM, Thomas Fanghaenel wrote: > On Mon, Jul 21, 2014 at 8:21 AM, Robert Haas wrote: >> The tests weren't running for me at all on MacOS X, because I was >> missing some prerequisite. So I installed it, and now they promptly >> fail: >> >> ok 2 - initdb --version >>

Re: [HACKERS] Portability issues in TAP tests

2014-07-21 Thread Thomas Fanghaenel
On Mon, Jul 21, 2014 at 8:21 AM, Robert Haas wrote: > The tests weren't running for me at all on MacOS X, because I was > missing some prerequisite. So I installed it, and now they promptly > fail: > > ok 2 - initdb --version > 1..2 > ok 1 - initdb with invalid option nonzero exit code >

Re: [HACKERS] Portability issues in TAP tests

2014-07-21 Thread Robert Haas
On Mon, Jul 21, 2014 at 10:06 AM, Christoph Berg wrote: > Re: Noah Misch 2014-07-18 <20140718052625.ga2231...@tornado.leadboat.com> >> Installing a new version of one Perl module is well within the capabilities >> of >> buildfarm owners. Saving them the trouble, which in turn means more of them

Re: [HACKERS] Portability issues in TAP tests

2014-07-21 Thread Christoph Berg
Re: Noah Misch 2014-07-18 <20140718052625.ga2231...@tornado.leadboat.com> > Installing a new version of one Perl module is well within the capabilities of > buildfarm owners. Saving them the trouble, which in turn means more of them > actually activating the TAP tests, might justify the loss. I'd

Re: [HACKERS] Portability issues in TAP tests

2014-07-17 Thread Tom Lane
Noah Misch writes: > On Thu, Jul 17, 2014 at 03:31:19PM -0400, Tom Lane wrote: >> 4. IPC::Run isn't installed by default on RHEL, and probably not on other >> distros either. If there's a reasonably painless way to remove this >> dependency, it'd improve the portability of the tests. This is low

Re: [HACKERS] Portability issues in TAP tests

2014-07-17 Thread Noah Misch
On Thu, Jul 17, 2014 at 03:31:19PM -0400, Tom Lane wrote: > My Salesforce colleagues have been complaining that the TAP tests added > in 9.4 don't work terribly well for them. I've been poking at this, > and I believe this is a reasonably complete list of the problems: > 3. Many of the tests depe

[HACKERS] Portability issues in TAP tests

2014-07-17 Thread Tom Lane
My Salesforce colleagues have been complaining that the TAP tests added in 9.4 don't work terribly well for them. I've been poking at this, and I believe this is a reasonably complete list of the problems: 1. "make [install]check-world" tries to run the TAP tests even when "prove" was not found b