Re: [HACKERS] Problems with extended-Query logging code

2006-09-07 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: I happened to notice that the recently added code to log Bind-message parameters was printing garbage into my log. On investigation it turned out to be trying to print an already-pfree'd string. That's fixable, Uh, can you show me

Re: [HACKERS] Problems with extended-Query logging code

2006-09-07 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: I happened to notice that the recently added code to log Bind-message parameters was printing garbage into my log. On investigation it turned out to be trying to print an already-pfree'd string. That's fixable,

[HACKERS] Problems with extended-Query logging code

2006-09-06 Thread Tom Lane
I happened to notice that the recently added code to log Bind-message parameters was printing garbage into my log. On investigation it turned out to be trying to print an already-pfree'd string. That's fixable, but having looked at the code closely, I see a bunch of other stuff I'm not happy

Re: [HACKERS] Problems with extended-Query logging code

2006-09-06 Thread Dave Cramer
On 6-Sep-06, at 6:01 PM, Tom Lane wrote: I happened to notice that the recently added code to log Bind-message parameters was printing garbage into my log. On investigation it turned out to be trying to print an already-pfree'd string. That's fixable, but having looked at the code

Re: [HACKERS] Problems with extended-Query logging code

2006-09-06 Thread Dave Cramer
On 6-Sep-06, at 6:17 PM, Tom Lane wrote: Dave Cramer [EMAIL PROTECTED] writes: On 6-Sep-06, at 6:01 PM, Tom Lane wrote: * It doesn't log the values of parameters sent in binary mode, which is something that at least JDBC needs. AFAIK, we don't need binary mode right away, currently we

Re: [HACKERS] Problems with extended-Query logging code

2006-09-06 Thread Bruce Momjian
Tom Lane wrote: I happened to notice that the recently added code to log Bind-message parameters was printing garbage into my log. On investigation it turned out to be trying to print an already-pfree'd string. That's fixable, Uh, can you show me where? but having looked at the code

Re: [HACKERS] Problems with extended-Query logging code

2006-09-06 Thread Tom Lane
Dave Cramer [EMAIL PROTECTED] writes: On 6-Sep-06, at 6:01 PM, Tom Lane wrote: * It doesn't log the values of parameters sent in binary mode, which is something that at least JDBC needs. AFAIK, we don't need binary mode right away, currently we only send bytea parameters in binary mode I

Re: [HACKERS] Problems with extended-Query logging code

2006-09-06 Thread Kris Jurka
On Wed, 6 Sep 2006, Tom Lane wrote: I thought somebody had mentioned that integers were also sent in binary in the latest driver code? Can't find the archive entry right now though. Using the fastpath protocol integers and oids are sent as binary. I don't know if that is related to this

Re: [HACKERS] Problems with extended-Query logging code

2006-09-06 Thread Abhijit Menon-Sen
At 2006-09-06 18:01:38 -0400, [EMAIL PROTECTED] wrote: That is, we'd log a Parse or Bind operation if it individually exceeded the duration threshold, and not otherwise. Ok. If we've got support for logging the statement text and the parameter values at Execute time, isn't logging the