Re: [HACKERS] Proposal: Integrity check

2008-05-12 Thread Zdenek Kotala
Alvaro Herrera napsal(a): Zdenek Kotala escribió: Regarding to Robert Mach's work during Google SOC on data integrity check. I would like to improve storage module and implement some Robert's code into the core. Did this go anywhere? I did not catch May commit fest :(. I plan to send cor

Re: [HACKERS] Proposal: Integrity check

2008-05-12 Thread Alvaro Herrera
Zdenek Kotala escribió: > Regarding to Robert Mach's work during Google SOC on data integrity > check. I would like to improve storage module and implement some > Robert's code into the core. Did this go anywhere? -- Alvaro Herrerahttp://www.CommandPrompt.com/

Re: [HACKERS] Proposal: Integrity check

2008-01-28 Thread Zdenek Kotala
Simon Riggs wrote: On Fri, 2008-01-25 at 17:56 +0100, Zdenek Kotala wrote: Regarding to Robert Mach's work during Google SOC on data integrity check. I would like to improve storage module and implement some Robert's code into the core. I would like to make following modification: 1) Add Rea

Re: [HACKERS] Proposal: Integrity check

2008-01-25 Thread Simon Riggs
On Fri, 2008-01-25 at 17:56 +0100, Zdenek Kotala wrote: > Regarding to Robert Mach's work during Google SOC on data integrity > check. I would like to improve storage module and implement some > Robert's code into the core. > > I would like to make following modification: > > 1) Add ReadBuffer_

Re: [HACKERS] Proposal: Integrity check

2008-01-25 Thread Zdenek Kotala
Tom Lane wrote: Zdenek Kotala <[EMAIL PROTECTED]> writes: I would like to make following modification: 1) Add ReadBuffer_noerror (recommend me better name) function which will accept damaged page without Error. This page will be marked as corrupted and when ReadBuffer will touch this page th

Re: [HACKERS] Proposal: Integrity check

2008-01-25 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Zdenek Kotala <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: >>> This seems like a pretty horrid idea. Bad pages shouldn't be allowed to >>> get into shared buffers in the first place. Why not have the checking >>> logic operate outside shared buffers? >

Re: [HACKERS] Proposal: Integrity check

2008-01-25 Thread Tom Lane
"Zeugswetter Andreas ADI SD" <[EMAIL PROTECTED]> writes: >> We're already assuming that; otherwise base backups for PITR >> don't work. > I think we could, but iirc we did not. We do not need that assumption if > you don't > turn off fullpage writes. Oh, I had forgotten that RestoreBkpBlocks re

Re: [HACKERS] Proposal: Integrity check

2008-01-25 Thread Zeugswetter Andreas ADI SD
> >> This seems like a pretty horrid idea. Bad pages shouldn't be allowed to > >> get into shared buffers in the first place. Why not have the checking > >> logic operate outside shared buffers? > > > It currently works outside the shared buffers, but I afraid about > > collision due to parall

Re: [HACKERS] Proposal: Integrity check

2008-01-25 Thread Tom Lane
Zdenek Kotala <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> This seems like a pretty horrid idea. Bad pages shouldn't be allowed to >> get into shared buffers in the first place. Why not have the checking >> logic operate outside shared buffers? > It currently works outside the shared buffers

Re: [HACKERS] Proposal: Integrity check

2008-01-25 Thread Tom Lane
Zdenek Kotala <[EMAIL PROTECTED]> writes: > I would like to make following modification: > 1) Add ReadBuffer_noerror (recommend me better name) function which will > accept damaged page without Error. This page will be marked as corrupted > and when ReadBuffer will touch this page then it will b

[HACKERS] Proposal: Integrity check

2008-01-25 Thread Zdenek Kotala
Regarding to Robert Mach's work during Google SOC on data integrity check. I would like to improve storage module and implement some Robert's code into the core. I would like to make following modification: 1) Add ReadBuffer_noerror (recommend me better name) function which will accept damage