Re: [HACKERS] Proposal for updating src/timezone

2014-10-03 Thread Tom Lane
I wrote: > The urgency of updating our timezone code has risen quite a bit for me, > because while testing an update of the data files to tzdata2014h I became > aware that the "-P" option is failing to print a noticeable number of > zone abbreviations that clearly exist in the data files. Since th

Re: [HACKERS] Proposal for updating src/timezone

2014-10-02 Thread Tom Lane
John Cochran writes: > As it is, I've finished checking the differences between the postgres and > IANA code for zic.c after editing both to eliminate non-functional style > differences such as indentation, function prototypes, comparing strchr > results against NULL or 0, etc. It looks like the o

Re: [HACKERS] Proposal for updating src/timezone

2014-07-19 Thread Gavin Flower
On 20/07/14 06:30, John Cochran wrote: On Sat, Jul 19, 2014 at 11:58 AM, Michael Banck > wrote: SNIP Maybe if you pgindent the IANA code as well, you can more easily diff the actual changes between the two, did you try that? Michael Unfortunately, pgind

Re: [HACKERS] Proposal for updating src/timezone

2014-07-19 Thread John Cochran
On Sat, Jul 19, 2014 at 11:58 AM, Michael Banck wrote: SNIP > > Maybe if you pgindent the IANA code as well, you can more easily diff > the actual changes between the two, did you try that? > > > Michael > Unfortunately, pgindent doesn't work well with the IANA code as evident by some previous ch

Re: [HACKERS] Proposal for updating src/timezone

2014-07-19 Thread Michael Banck
Hi, On Sat, Jul 19, 2014 at 09:28:25AM -0400, John Cochran wrote: > Agreed. Right now, I'm seeing about updating zic.c to match the IANA code > combined with the modifications that postgres did to it. So far, it doesn't > look like many functional changes have been done, but due to the use of > pg

Re: [HACKERS] Proposal for updating src/timezone

2014-07-19 Thread John Cochran
Agreed. Right now, I'm seeing about updating zic.c to match the IANA code combined with the modifications that postgres did to it. So far, it doesn't look like many functional changes have been done, but due to the use of pgindent, there's a LOT of cosmetic changes that add one heck of a lot of noi

Re: [HACKERS] Proposal for updating src/timezone

2014-07-18 Thread Tom Lane
John Cochran writes: > Did a diff between the 2010c version of localtime.c and the postgres > version and saw a lot more differences than what could have been expected > from simple reformatting and adaptation. So I installed gitk and took a > look at the change history of localtime.c > Well,

Re: [HACKERS] Proposal for updating src/timezone

2014-07-18 Thread John Cochran
On Fri, Jul 18, 2014 at 1:21 PM, Tom Lane wrote: > John Cochran writes: > > My proposal is the have the following directory structure > > ... > > 1. I would have liked to recommend 2 sub-directories underneath > ... > > I have exactly zero expectation of using their Makefile, so this is not a

Re: [HACKERS] Proposal for updating src/timezone

2014-07-18 Thread Tom Lane
John Cochran writes: > My proposal is the have the following directory structure > .../src/timezone - Would have only PostgreSQL specific code > .../src/timezone/tznames - would be unaltered from current (optionally this > could be removed) > .../src/timezone/iana - would contain unaltered code a

[HACKERS] Proposal for updating src/timezone

2014-07-18 Thread John Cochran
Given my recent examination of the src/timezone subtree and the current code at IANA for timezone information and tools, I proposing the following changes and would like to first get group consensus on the change prior to investing any major effort. My proposal is the have the following directory