Re: [HACKERS] REVIEW: pg_stat_statements with query tree based normalization

2012-01-21 Thread Kääriäinen Anssi
I am going to produce another revision in response to feedback already received. I intend to outline the steps that it will take to resolve some outstanding issues in the next day or so. It would be nice if you could take a look at the revised patch that is ultimately produced. Should I keep you

[HACKERS] REVIEW: pg_stat_statements with query tree based normalization

2012-01-20 Thread Kääriäinen Anssi
This is a short review of pg_stat_statements based on quick testing of the feature. 1. Installation: after managing to actually build PostgreSQL and contrib modules + changing shared_preload_libraries to include pg_stat_statements I got this error: FATAL: could not create shared memory

Re: [HACKERS] REVIEW: pg_stat_statements with query tree based normalization

2012-01-20 Thread Peter Geoghegan
On 21 January 2012 00:24, Kääriäinen Anssi anssi.kaariai...@thl.fi wrote: I did not see any noticeable difference in runtimes with pg_stat_statements installed or uninstalled (as extension). Not tested on master without the patch at all. Overall the feature seems to be really useful. Thanks