[HACKERS] RangeTblEntry.joinaliasvars representation change

2013-07-22 Thread Tom Lane
In http://www.postgresql.org/message-id/cak_s-g3-fwveer1c0idvtz0745-7ryifi8whbzcnmsn+hwc...@mail.gmail.com it's pointed out that commit 2ffa740b was a few bricks shy of a load, because it failed to cope with the possibility of a joinaliasvars item containing an implicit coercion. That's not too

Re: [HACKERS] RangeTblEntry.joinaliasvars representation change

2013-07-22 Thread Tom Lane
I wrote: After some reflection I think that the best fix is to redefine AcquireRewriteLocks' processing of dropped columns so that it puts an actual null pointer, not a consed-up Const, into the joinaliasvars list item. Here's a complete patch along that line. Possibly worthy of note is that