[HACKERS] Re: [COMMITTERS] pgsql: Ensure that top level aborts call XLogSetAsyncCommit().

2010-07-16 Thread Fujii Masao
On Mon, May 31, 2010 at 8:48 PM, Simon Riggs si...@2ndquadrant.com wrote: On Mon, 2010-05-31 at 20:11 +0900, Fujii Masao wrote: On Thu, May 13, 2010 at 8:39 PM, Simon Riggs sri...@postgresql.org wrote: Log Message: --- Ensure that top level aborts call XLogSetAsyncCommit(). Not

[HACKERS] Re: [COMMITTERS] pgsql: Ensure that top level aborts call XLogSetAsyncCommit().

2010-07-16 Thread Simon Riggs
On Fri, 2010-07-16 at 17:03 +0900, Fujii Masao wrote: This commit changed XLogSetAsyncCommitLSN() so that it's called for abort case. So we need to change the comment of the function as follows: Agreed, will fix. Will also rename function to better document its new role. New

[HACKERS] Re: [COMMITTERS] pgsql: Ensure that top level aborts call XLogSetAsyncCommit().

2010-05-31 Thread Fujii Masao
On Thu, May 13, 2010 at 8:39 PM, Simon Riggs sri...@postgresql.org wrote: Log Message: --- Ensure that top level aborts call XLogSetAsyncCommit(). Not doing so simply leads to data waiting in wal_buffers which then causes later commits to potentially do emergency writes and for all

[HACKERS] Re: [COMMITTERS] pgsql: Ensure that top level aborts call XLogSetAsyncCommit().

2010-05-31 Thread Simon Riggs
On Mon, 2010-05-31 at 20:11 +0900, Fujii Masao wrote: On Thu, May 13, 2010 at 8:39 PM, Simon Riggs sri...@postgresql.org wrote: Log Message: --- Ensure that top level aborts call XLogSetAsyncCommit(). Not doing so simply leads to data waiting in wal_buffers which then causes