Re: [HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-14 Thread Robert Haas
On Fri, Oct 14, 2016 at 11:00 AM, Tom Lane wrote: > Robert Haas writes: >> On Fri, Oct 14, 2016 at 9:43 AM, Tom Lane wrote: >>> TBH, I can't muster much sympathy for that position. Make a test case >>> for it, and the problem goes

Re: [HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-14 Thread Tom Lane
Robert Haas writes: > On Fri, Oct 14, 2016 at 9:43 AM, Tom Lane wrote: >> TBH, I can't muster much sympathy for that position. Make a test case >> for it, and the problem goes away, not to mention that confidence in >> whether it actually works (not

Re: [HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-14 Thread Robert Haas
On Fri, Oct 14, 2016 at 9:43 AM, Tom Lane wrote: > Robert Haas writes: >> On Fri, Oct 14, 2016 at 9:10 AM, Tom Lane wrote: >>> Well, if it has no tests *and* it's not getting installed, what's >>> the point of having it at all? > >>

Re: [HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-14 Thread Tom Lane
Robert Haas writes: > On Fri, Oct 14, 2016 at 9:10 AM, Tom Lane wrote: >> Well, if it has no tests *and* it's not getting installed, what's >> the point of having it at all? > It's intended as a demonstration of stuff you could do with background >

Re: [HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-14 Thread Robert Haas
On Fri, Oct 14, 2016 at 9:10 AM, Tom Lane wrote: > Robert Haas writes: >> On Fri, Oct 14, 2016 at 8:33 AM, Tom Lane wrote: >>> Not sure. There's something to be said for the equivalence Peter >>> proposes above. What you actually

Re: [HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-14 Thread Tom Lane
Robert Haas writes: > On Fri, Oct 14, 2016 at 8:33 AM, Tom Lane wrote: >> Not sure. There's something to be said for the equivalence Peter >> proposes above. What you actually wanted, as I understood it, was >> that "make world" plus "make

Re: [HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-14 Thread Robert Haas
On Fri, Oct 14, 2016 at 8:33 AM, Tom Lane wrote: > Robert Haas writes: >> On Thu, Oct 13, 2016 at 9:23 PM, Peter Eisentraut >> wrote: >>> Well, the purpose of make all or make world is to build the things that >>> are

Re: [HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-14 Thread Tom Lane
Robert Haas writes: > On Thu, Oct 13, 2016 at 9:23 PM, Peter Eisentraut > wrote: >> Well, the purpose of make all or make world is to build the things that >> are to be installed by make install or make install-world, which is the >> stuff

Re: [HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-14 Thread Robert Haas
On Thu, Oct 13, 2016 at 9:23 PM, Peter Eisentraut wrote: > On 10/12/16 7:38 PM, Andres Freund wrote: >>> We generally don't build test code during make world. >> FWIW, I find that quite annoying. I want to run make world with parallelism >> so >> I can run make

Re: [HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-13 Thread Peter Eisentraut
On 10/12/16 7:38 PM, Andres Freund wrote: >> We generally don't build test code during make world. > FWIW, I find that quite annoying. I want to run make world with parallelism so > I can run make world afterwards with as little unnecessary > unparallelized work. And since the latter takes just

Re: [HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-13 Thread Peter Eisentraut
On 10/12/16 12:04 PM, Robert Haas wrote: > But it's annoying to push code and have it break the buildfarm when > you already did 'make world' and 'make check-world'. What target > should I be using? I don't know why worker_spi is not tested by check-world. It should clearly do that. -- Peter

Re: [HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-12 Thread Michael Paquier
On Thu, Oct 13, 2016 at 8:38 AM, Andres Freund wrote: > On 2016-10-12 11:18:57 -0400, Peter Eisentraut wrote: >> On 10/4/16 11:29 AM, Tom Lane wrote: >> > Robert Haas writes: >> >> Apparently, 'make world' does not build worker_spi. I thought 'make >>

Re: [HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-12 Thread Andres Freund
On 2016-10-12 11:18:57 -0400, Peter Eisentraut wrote: > On 10/4/16 11:29 AM, Tom Lane wrote: > > Robert Haas writes: > >> Apparently, 'make world' does not build worker_spi. I thought 'make > >> world' was supposed to build everything? > > > > You'd have thunk, yeah. It

[HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-12 Thread Robert Haas
On Wed, Oct 12, 2016 at 8:18 AM, Peter Eisentraut wrote: > On 10/4/16 11:29 AM, Tom Lane wrote: >> Robert Haas writes: >>> Apparently, 'make world' does not build worker_spi. I thought 'make >>> world' was supposed to build everything? >>

[HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-12 Thread Peter Eisentraut
On 10/4/16 11:29 AM, Tom Lane wrote: > Robert Haas writes: >> Apparently, 'make world' does not build worker_spi. I thought 'make >> world' was supposed to build everything? > > You'd have thunk, yeah. It looks like the issue is that src/Makefile > is selective about

Re: [HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-04 Thread Alvaro Herrera
Robert Haas wrote: > On Tue, Oct 4, 2016 at 11:29 AM, Tom Lane wrote: > > Robert Haas writes: > >> Apparently, 'make world' does not build worker_spi. I thought 'make > >> world' was supposed to build everything? > > > > You'd have thunk, yeah. It

[HACKERS] Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-04 Thread Robert Haas
On Tue, Oct 4, 2016 at 11:29 AM, Tom Lane wrote: > Robert Haas writes: >> Apparently, 'make world' does not build worker_spi. I thought 'make >> world' was supposed to build everything? > > You'd have thunk, yeah. It looks like the issue is that