Re: [HACKERS] Re: [COMMITTERS] pgsql: Permit dump/reload of not-too-large >1GB tuples

2016-12-09 Thread Alvaro Herrera 
Alvaro Herrera wrote:
> Tom Lane wrote:
> > Alvaro Herrera  writes:
> > > Permit dump/reload of not-too-large >1GB tuples
> > 
> > I apologize for not having paid close enough attention earlier, but:
> > this patch is absolutely unacceptable for the back branches and MUST
> > be reverted there.  Adding another field to StringInfoData is an ABI
> > change that will certainly break large numbers of extensions.  We
> > can't expect those to get recompiled for minor releases.
> 
> Oh, I see the problem now -- it can (and frequently is) stack allocated,
> not just palloc'ed using the StringInfo api, and changing the size
> breaks that.  Rats.  I'll revert tomorrow.

Done.

-- 
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Re: [COMMITTERS] pgsql: Permit dump/reload of not-too-large >1GB tuples

2016-12-05 Thread Alvaro Herrera 
Tom Lane wrote:
> Alvaro Herrera  writes:
> > Permit dump/reload of not-too-large >1GB tuples
> 
> I apologize for not having paid close enough attention earlier, but:
> this patch is absolutely unacceptable for the back branches and MUST
> be reverted there.  Adding another field to StringInfoData is an ABI
> change that will certainly break large numbers of extensions.  We
> can't expect those to get recompiled for minor releases.

Oh, I see the problem now -- it can (and frequently is) stack allocated,
not just palloc'ed using the StringInfo api, and changing the size
breaks that.  Rats.  I'll revert tomorrow.

-- 
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers