Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-29 Thread David Fetter
On Mon, Nov 29, 2010 at 02:09:29PM -0500, Tom Lane wrote: > Magnus Hagander writes: > > On Mon, Nov 29, 2010 at 16:26, Robert Haas wrote: > >> That works for me. �But should we make a practice of writing the > >> ENTIRE SHA-ID rather than an abbreviated form, so that we could more > >> easily rep

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-29 Thread Tom Lane
Magnus Hagander writes: > On Mon, Nov 29, 2010 at 16:26, Robert Haas wrote: >> That works for me.  But should we make a practice of writing the >> ENTIRE SHA-ID rather than an abbreviated form, so that we could more >> easily replace 'em later if need be? > I think that's a good idea. Just as a

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-29 Thread Magnus Hagander
On Mon, Nov 29, 2010 at 16:26, Robert Haas wrote: > On Mon, Nov 29, 2010 at 7:45 AM, Magnus Hagander wrote: >>> Let's do both: "This fixes the bug introduced by the foobar patch from Sep >>> 12th (git commitid a2c23897bc). >>> >>> I like to see the date of the referred patch in the commit message

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-29 Thread Robert Haas
On Mon, Nov 29, 2010 at 7:45 AM, Magnus Hagander wrote: >> Let's do both: "This fixes the bug introduced by the foobar patch from Sep >> 12th (git commitid a2c23897bc). >> >> I like to see the date of the referred patch in the commit message, to get >> an immediate idea of whether it was a 5-year

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-29 Thread Magnus Hagander
On Mon, Nov 29, 2010 at 13:42, Heikki Linnakangas wrote: > On 28.11.2010 06:59, Robert Haas wrote: >> >> On Sat, Nov 27, 2010 at 3:46 PM, Tom Lane  wrote: >>> >>> Robert Haas  writes: On Nov 27, 2010, at 2:49 PM, Bruce Momjian  wrote: > > Who's going to be the first to say that b

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-29 Thread Heikki Linnakangas
On 28.11.2010 06:59, Robert Haas wrote: On Sat, Nov 27, 2010 at 3:46 PM, Tom Lane wrote: Robert Haas writes: On Nov 27, 2010, at 2:49 PM, Bruce Momjian wrote: Who's going to be the first to say that being git-centric can't ever be a bad thing? ;-) At least for me, referring to it that w

[HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-27 Thread Robert Haas
On Sat, Nov 27, 2010 at 3:46 PM, Tom Lane wrote: > Robert Haas writes: >> On Nov 27, 2010, at 2:49 PM, Bruce Momjian wrote: >>> Who's going to be the first to say that being git-centric can't ever be >>> a bad thing?  ;-) > >> At least for me, referring to it that way makes finding the original

[HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-27 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Robert Haas wrote: > >> Remove outdated comments from the regression test files. > >> > >> Since 2004, int2 and int4 operators do detect overflow; this was fixed by > >> commit 4171bb869f234281a13bb862d3b1e577bf336242. > >> > >> Extracted from a larger