Re: [HACKERS] Re: [COMMITTERS] pgsql: Run pgindent on 9.2 source tree in preparation for first 9.3

2012-07-04 Thread Bruce Momjian
On Tue, Jun 12, 2012 at 02:40:09PM -0400, Robert Haas wrote: > On Tue, Jun 12, 2012 at 2:02 PM, Bruce Momjian wrote: > > On Tue, Jun 12, 2012 at 01:50:48PM -0400, Noah Misch wrote: > >> On Mon, Jun 11, 2012 at 05:57:41PM -0400, Alvaro Herrera wrote: > >> > What about something like this in the roo

[HACKERS] Re: [COMMITTERS] pgsql: Run pgindent on 9.2 source tree in preparation for first 9.3

2012-06-16 Thread Bruce Momjian
On Sat, Jun 16, 2012 at 01:10:31AM -0400, Noah Misch wrote: > On Fri, Jun 15, 2012 at 10:45:16PM -0400, Bruce Momjian wrote: > > I have updated the pgindent README to use > > these Perl indent instructions: > > > > find . -name \*.pl -o -name \*.pm | xargs perltidy \ > > --backup-a

[HACKERS] Re: [COMMITTERS] pgsql: Run pgindent on 9.2 source tree in preparation for first 9.3

2012-06-15 Thread Noah Misch
On Fri, Jun 15, 2012 at 10:45:16PM -0400, Bruce Momjian wrote: > I have updated the pgindent README to use > these Perl indent instructions: > > find . -name \*.pl -o -name \*.pm | xargs perltidy \ > --backup-and-modify-in-place --opening-brace-on-new-line \ > --vertical-ti

Re: [HACKERS] Re: [COMMITTERS] pgsql: Run pgindent on 9.2 source tree in preparation for first 9.3

2012-06-15 Thread Bruce Momjian
On Fri, Jun 15, 2012 at 10:48:27PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > OK, based on this feedback, I have updated the pgindent README to use > > these Perl indent instructions: > > > find . -name \*.pl -o -name \*.pm | xargs perltidy \ > > --backup-and-modify-in-pla

Re: [HACKERS] Re: [COMMITTERS] pgsql: Run pgindent on 9.2 source tree in preparation for first 9.3

2012-06-15 Thread Tom Lane
Bruce Momjian writes: > OK, based on this feedback, I have updated the pgindent README to use > these Perl indent instructions: > find . -name \*.pl -o -name \*.pm | xargs perltidy \ > --backup-and-modify-in-place --opening-brace-on-new-line \ > --vertical-tightness=2 --ve

[HACKERS] Re: [COMMITTERS] pgsql: Run pgindent on 9.2 source tree in preparation for first 9.3

2012-06-15 Thread Bruce Momjian
On Tue, Jun 12, 2012 at 01:50:48PM -0400, Noah Misch wrote: > On Mon, Jun 11, 2012 at 05:57:41PM -0400, Alvaro Herrera wrote: > > What about something like this in the root of the tree: > > find . -name \*.pl -o -name \*.pm | xargs perltidy -b -bl -nsfs -naws > > -l=100 -ole=unix > > > > There ar

Re: [HACKERS] Re: [COMMITTERS] pgsql: Run pgindent on 9.2 source tree in preparation for first 9.3

2012-06-12 Thread Robert Haas
On Tue, Jun 12, 2012 at 2:02 PM, Bruce Momjian wrote: > On Tue, Jun 12, 2012 at 01:50:48PM -0400, Noah Misch wrote: >> On Mon, Jun 11, 2012 at 05:57:41PM -0400, Alvaro Herrera wrote: >> > What about something like this in the root of the tree: >> > find . -name \*.pl -o -name \*.pm | xargs perltid

[HACKERS] Re: [COMMITTERS] pgsql: Run pgindent on 9.2 source tree in preparation for first 9.3

2012-06-12 Thread Bruce Momjian
On Tue, Jun 12, 2012 at 01:50:48PM -0400, Noah Misch wrote: > On Mon, Jun 11, 2012 at 05:57:41PM -0400, Alvaro Herrera wrote: > > What about something like this in the root of the tree: > > find . -name \*.pl -o -name \*.pm | xargs perltidy -b -bl -nsfs -naws > > -l=100 -ole=unix > > > > There ar

[HACKERS] Re: [COMMITTERS] pgsql: Run pgindent on 9.2 source tree in preparation for first 9.3

2012-06-12 Thread Noah Misch
On Mon, Jun 11, 2012 at 05:57:41PM -0400, Alvaro Herrera wrote: > What about something like this in the root of the tree: > find . -name \*.pl -o -name \*.pm | xargs perltidy -b -bl -nsfs -naws -l=100 > -ole=unix > > There are files all over the place. The file that would most be > affected with

[HACKERS] Re: [COMMITTERS] pgsql: Run pgindent on 9.2 source tree in preparation for first 9.3

2012-06-12 Thread Bruce Momjian
On Mon, Jun 11, 2012 at 05:57:41PM -0400, Alvaro Herrera wrote: > > Excerpts from Bruce Momjian's message of lun jun 11 15:44:16 -0400 2012: > > > > On Mon, Jun 11, 2012 at 12:20:13PM -0400, Alvaro Herrera wrote: > > > > > Hm, does this touch stuff that would also be modified by perltidy? I > >

[HACKERS] Re: [COMMITTERS] pgsql: Run pgindent on 9.2 source tree in preparation for first 9.3

2012-06-11 Thread Bruce Momjian
On Mon, Jun 11, 2012 at 12:20:13PM -0400, Alvaro Herrera wrote: > > > Hm, does this touch stuff that would also be modified by perltidy? I > > > wonder if we should refrain from doing entab/detab on perl files and > > > instead have perltidy touch such code. > > > The Perl files were modified by

[HACKERS] Re: [COMMITTERS] pgsql: Run pgindent on 9.2 source tree in preparation for first 9.3

2012-06-10 Thread Bruce Momjian
On Sun, Jun 10, 2012 at 08:55:13PM -0400, Alvaro Herrera wrote: > > Excerpts from Bruce Momjian's message of dom jun 10 15:20:34 -0400 2012: > > Run pgindent on 9.2 source tree in preparation for first 9.3 > > commit-fest. > > Hm, does this touch stuff that would also be modified by perltidy? I