[HACKERS] Re: [HACKERS] Re: [PATCH] Tab completion for ALTER TYPE … RENAME VALUE …

[Robert Haas]

On Tue, Nov 8, 2016 at 8:53 AM, Dagfinn Ilmari Mannsåker
 wrote:
> Thank you very much.  I just looked at the patch again and realised the
> completion of "TO" after RENAME VALUE  can be merged with the one
> for RENAME ATTRIBUTE .  Attached is an updated and patch

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Re: [HACKERS] Re: [PATCH] Tab completion for ALTER TYPE … RENAME VALUE …

[Artur Zakirov]

Hello,

2016-09-12 16:16 GMT+03:00 Dagfinn Ilmari Mannsåker :
>
> I've added it to the 2016-11 commit fest:
> https://commitfest.postgresql.org/11/795/
>
> - ilmari

I've tested your patch.

Patch was applied to the master. It seems there is no need to rebase
it. PostgreSQL was compiled without errors with the patch.

I've tested the patch with type:

CREATE TYPE rainbow AS ENUM ('red', 'orange', 'yellow', 'green',
'blue', 'purple');

And the following completions work as expected:

=> ALTER TYPE rainbow RENAME 
ATTRIBUTE  TO VALUE

=> ALTER TYPE rainbow RENAME VALUE 
'blue''green'   'orange'  'purple'  'red' 'yellow'

It seems that the patch can be commited without any fixes. So I marked
it as "Ready for Committer".

-- 
Sincerely,
Artur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers