Re: [HACKERS] Re: proposal - using names as primary names of plpgsql function parameters instead $ based names

2017-09-11 Thread Pavel Stehule
2017-09-11 22:28 GMT+02:00 Tom Lane : > Jeevan Chalke writes: > [ psql-named-arguments-03-jeevan.patch ] > > Pushed with minor simplification of the test case. > > I'm not quite as convinced as Pavel that this is an improvement --- > it will

Re: [HACKERS] Re: proposal - using names as primary names of plpgsql function parameters instead $ based names

2017-09-11 Thread Tom Lane
Jeevan Chalke writes: [ psql-named-arguments-03-jeevan.patch ] Pushed with minor simplification of the test case. I'm not quite as convinced as Pavel that this is an improvement --- it will make error messages inconsistent between named and unnamed arguments.

Re: [HACKERS] Re: proposal - using names as primary names of plpgsql function parameters instead $ based names

2017-09-11 Thread Pavel Stehule
2017-09-11 9:46 GMT+02:00 Jeevan Chalke : > Hi Pavel, > > > On Sat, Sep 9, 2017 at 11:42 AM, Pavel Stehule > wrote: > >> Hi >> >> 2017-09-08 9:36 GMT+02:00 Jeevan Chalke : >> >>> Hi Pavel, >>> I like the

Re: [HACKERS] Re: proposal - using names as primary names of plpgsql function parameters instead $ based names

2017-09-11 Thread Jeevan Chalke
Hi Pavel, On Sat, Sep 9, 2017 at 11:42 AM, Pavel Stehule wrote: > Hi > > 2017-09-08 9:36 GMT+02:00 Jeevan Chalke : > >> Hi Pavel, >> I like the idea of using parameter name instead of $n symbols. >> >> However, I am slightly worried

Re: [HACKERS] Re: proposal - using names as primary names of plpgsql function parameters instead $ based names

2017-09-09 Thread Pavel Stehule
Hi 2017-09-08 9:36 GMT+02:00 Jeevan Chalke : > Hi Pavel, > > On Sat, May 20, 2017 at 11:55 AM, Pavel Stehule > wrote: > >> >> >> >> 2017-05-19 5:48 GMT+02:00 Pavel Stehule : >> >>> >>> >>> 2017-05-19 3:14

Re: [HACKERS] Re: proposal - using names as primary names of plpgsql function parameters instead $ based names

2017-09-08 Thread Jeevan Chalke
Hi Pavel, On Sat, May 20, 2017 at 11:55 AM, Pavel Stehule wrote: > > > > 2017-05-19 5:48 GMT+02:00 Pavel Stehule : > >> >> >> 2017-05-19 3:14 GMT+02:00 Peter Eisentraut > com>: >> >>> On 5/15/17 14:34, Pavel

Re: [HACKERS] Re: proposal - using names as primary names of plpgsql function parameters instead $ based names

2017-05-20 Thread Pavel Stehule
2017-05-19 5:48 GMT+02:00 Pavel Stehule : > > > 2017-05-19 3:14 GMT+02:00 Peter Eisentraut com>: > >> On 5/15/17 14:34, Pavel Stehule wrote: >> > Now, I when I working on plpgsql_check, I have to check function >> > parameters. I

Re: [HACKERS] Re: proposal - using names as primary names of plpgsql function parameters instead $ based names

2017-05-18 Thread Pavel Stehule
2017-05-19 3:14 GMT+02:00 Peter Eisentraut : > On 5/15/17 14:34, Pavel Stehule wrote: > > Now, I when I working on plpgsql_check, I have to check function > > parameters. I can use fn_vargargnos and out_param_varno for list of > > arguments and

Re: [HACKERS] Re: proposal - using names as primary names of plpgsql function parameters instead $ based names

2017-05-18 Thread Peter Eisentraut
On 5/15/17 14:34, Pavel Stehule wrote: > Now, I when I working on plpgsql_check, I have to check function > parameters. I can use fn_vargargnos and out_param_varno for list of > arguments and related varno(s). when I detect some issue, I am using > refname. It is not too nice now,

[HACKERS] Re: proposal - using names as primary names of plpgsql function parameters instead $ based names

2017-05-15 Thread Pavel Stehule
2017-05-13 18:26 GMT+02:00 Pavel Stehule : > Hi > > Now, I when I working on plpgsql_check, I have to check function > parameters. I can use fn_vargargnos and out_param_varno for list of > arguments and related varno(s). when I detect some issue, I am using > refname. It