Re: [HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility)

2017-10-30 Thread Badrul Chowdhury
--- >> From: Robert Haas [mailto:robertmh...@gmail.com] >> Sent: Friday, October 27, 2017 5:56 AM >> To: Badrul Chowdhury >> Cc: Tom Lane ; Satyanarayana Narlapuram >> ; Craig Ringer >> ; Peter Eisentraut ; Magnus >> Hagander ; PostgreSQL-development > hack...@

Re: [HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility)

2017-10-27 Thread Robert Haas
On Thu, Oct 19, 2017 at 1:35 AM, Badrul Chowdhury wrote: > The new functionality is for sending 64bit ints. I think 32bits is sufficient > for the information we want to pass around in the protocol negotiation phase, > so I left this part unchanged. No, it isn't. That commit didn't add any new

Re: [HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility)

2017-10-18 Thread Badrul Chowdhury
gt;> -Original Message- >> From: Robert Haas [mailto:robertmh...@gmail.com] >> Sent: Friday, October 13, 2017 11:16 AM >> To: Badrul Chowdhury >> Cc: Tom Lane ; Satyanarayana Narlapuram >> ; Craig Ringer >> ; Peter Eisentraut ; Magnus >> Ha

Re: [HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility)

2017-10-13 Thread Robert Haas
On Fri, Oct 6, 2017 at 5:07 PM, Badrul Chowdhury wrote: > I added a mechanism to fall back to v3.0 if the BE fails to start when FE > initiates a connection with v3.1 (with optional startup parameters). This > completely eliminates the need to backpatch older servers, ie newer FE can > connect

Re: [HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility)

2017-10-06 Thread Badrul Chowdhury
: [HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility) On Tue, Oct 3, 2017 at 9:46 PM, Tom Lane wrote: > Badrul Chowdhury writes: >> 1. Pgwire protocol v3.0 with negotiation is called v3.1. >> 2. There are 2 patches for the change: a BE-spec

Re: [HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility)

2017-10-04 Thread Badrul Chowdhury
...@gmail.com] Sent: Wednesday, October 4, 2017 4:54 AM To: Tom Lane Cc: Badrul Chowdhury ; Satyanarayana Narlapuram ; Craig Ringer ; Peter Eisentraut ; Magnus Hagander ; PostgreSQL-development Subject: Re: [HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version

Re: [HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility)

2017-10-04 Thread Robert Haas
On Tue, Oct 3, 2017 at 9:46 PM, Tom Lane wrote: > Badrul Chowdhury writes: >> 1. Pgwire protocol v3.0 with negotiation is called v3.1. >> 2. There are 2 patches for the change: a BE-specific patch that will be >> backported and a FE-specific patch that is only for pg10 and above. > > TBH, anythi

Re: [HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility)

2017-10-03 Thread Tom Lane
Badrul Chowdhury writes: > 1. Pgwire protocol v3.0 with negotiation is called v3.1. > 2. There are 2 patches for the change: a BE-specific patch that will be > backported and a FE-specific patch that is only for pg10 and above. TBH, anything that presupposes a backported change in the backend is

[HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility)

2017-10-03 Thread Badrul Chowdhury
Hello, Kindly review this patch that implements the proposal for pgwire protocol negotiation described in this thread. A big thanks to @Satyanarayana Narlapuram for his help and guidance in implementing the patch. Please note: 1. Pgwire protocol