Re: [HACKERS] Re-indent HEAD tomorrow?

2017-06-22 Thread Bruce Momjian
On Thu, Jun 22, 2017 at 10:38:41AM -0400, Robert Haas wrote: > On Wed, Jun 21, 2017 at 5:28 PM, Tom Lane wrote: > > Right now we're really just speculating about how much pain there will > > be, on either end of this. So it'd be interesting for somebody who's > > carrying large out-of-tree patche

Re: [HACKERS] Re-indent HEAD tomorrow?

2017-06-22 Thread Robert Haas
On Wed, Jun 21, 2017 at 5:28 PM, Tom Lane wrote: > Right now we're really just speculating about how much pain there will > be, on either end of this. So it'd be interesting for somebody who's > carrying large out-of-tree patches (EDB? Citus?) to try the new > pgindent version on a back branch an

Re: [HACKERS] Re-indent HEAD tomorrow?

2017-06-21 Thread Tom Lane
Andres Freund writes: > On 2017-06-21 17:28:32 -0400, Tom Lane wrote: >> And I think it'd make sense to wait a few >> months and garner some experience with back-patching from v10 into the >> older branches, so we have more than guesses about how much pain not >> reindenting will be for us. > Hm.

Re: [HACKERS] Re-indent HEAD tomorrow?

2017-06-21 Thread Andres Freund
On 2017-06-21 17:28:32 -0400, Tom Lane wrote: > Right now we're really just speculating about how much pain there will > be, on either end of this. So it'd be interesting for somebody who's > carrying large out-of-tree patches (EDB? Citus?) to try the new > pgindent version on a back branch and se

Re: [HACKERS] Re-indent HEAD tomorrow?

2017-06-21 Thread Tom Lane
Bruce Momjian writes: > On Wed, Jun 21, 2017 at 04:07:30PM -0400, Tom Lane wrote: >> ... and it's done. > You are eventually doing all active branches, right? I don't think we'd entirely decided that we should do that, or when to do it. I'm not in a huge hurry; we might find some more tweaks we

Re: [HACKERS] Re-indent HEAD tomorrow?

2017-06-21 Thread Bruce Momjian
On Wed, Jun 21, 2017 at 04:07:30PM -0400, Tom Lane wrote: > I wrote: > > Barring objections, I'd like to reindent HEAD with the new version > > of pg_bsd_indent (and correspondingly updated pgindent script) > > tomorrow, say around 1800 UTC. > > ... and it's done. You are eventually doing all act

Re: [HACKERS] Re-indent HEAD tomorrow?

2017-06-21 Thread Tom Lane
I wrote: > Barring objections, I'd like to reindent HEAD with the new version > of pg_bsd_indent (and correspondingly updated pgindent script) > tomorrow, say around 1800 UTC. ... and it's done. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@pos

[HACKERS] Re-indent HEAD tomorrow?

2017-06-20 Thread Tom Lane
Barring objections, I'd like to reindent HEAD with the new version of pg_bsd_indent (and correspondingly updated pgindent script) tomorrow, say around 1800 UTC. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to you