Re: [HACKERS] Recovery conflict monitoring

2011-01-03 Thread Magnus Hagander
On Mon, Jan 3, 2011 at 00:23, Simon Riggs si...@2ndquadrant.com wrote: On Mon, 2010-12-27 at 14:39 +0100, Magnus Hagander wrote: On Thu, Dec 23, 2010 at 13:09, Magnus Hagander mag...@hagander.net wrote: This patch adds counters and views to monitor hot standby generated recovery conflicts.

Re: [HACKERS] Recovery conflict monitoring

2011-01-03 Thread Simon Riggs
On Mon, 2011-01-03 at 10:03 +0100, Magnus Hagander wrote: I like the patch, well inspired, code in the right places AFAICS. No code comments at all. Thanks for reviewing! All good here. Test and commit please. -- Simon Riggs http://www.2ndQuadrant.com/books/ PostgreSQL

Re: [HACKERS] Recovery conflict monitoring

2011-01-03 Thread Greg Smith
Couple of doc suggestions: --- doc/src/sgml/high-availability.sgml + The number of query cancels and the reason for them can be viewed using + the structnamepg_stat_database_conflicts/ system view on the slave + server. For compleness sake, this should also mention the

Re: [HACKERS] Recovery conflict monitoring

2011-01-03 Thread Magnus Hagander
On Mon, Jan 3, 2011 at 11:35, Greg Smith g...@2ndquadrant.com wrote: Couple of doc suggestions: --- doc/src/sgml/high-availability.sgml +     The number of query cancels and the reason for them can be viewed using +     the structnamepg_stat_database_conflicts/ system view on the slave +    

Re: [HACKERS] Recovery conflict monitoring

2011-01-02 Thread Simon Riggs
On Mon, 2010-12-27 at 14:39 +0100, Magnus Hagander wrote: On Thu, Dec 23, 2010 at 13:09, Magnus Hagander mag...@hagander.net wrote: This patch adds counters and views to monitor hot standby generated recovery conflicts. It extends the pg_stat_database view with one column with the total

Re: [HACKERS] Recovery conflict monitoring

2010-12-27 Thread Magnus Hagander
On Thu, Dec 23, 2010 at 13:09, Magnus Hagander mag...@hagander.net wrote: This patch adds counters and views to monitor hot standby generated recovery conflicts. It extends the pg_stat_database view with one column with the total number of conflicts, and also creates a new view

[HACKERS] Recovery conflict monitoring

2010-12-23 Thread Magnus Hagander
This patch adds counters and views to monitor hot standby generated recovery conflicts. It extends the pg_stat_database view with one column with the total number of conflicts, and also creates a new view pg_stat_database_conflicts that contains a breakdown of exactly what caused the conflicts.