Re: [HACKERS] Redundant check of em_is_child

2017-06-22 Thread Amit Langote
On 2017/06/23 0:00, Robert Haas wrote: > On Fri, May 19, 2017 at 3:46 AM, Amit Langote > wrote: >> In match_eclasses_to_foreign_key_col(), there is this: >> >> if (em->em_is_child) >> continue; /* ignore children here */ >> >> ISTM,

Re: [HACKERS] Redundant check of em_is_child

2017-06-22 Thread Robert Haas
On Fri, May 19, 2017 at 3:46 AM, Amit Langote wrote: > In match_eclasses_to_foreign_key_col(), there is this: > > if (em->em_is_child) > continue; /* ignore children here */ > > ISTM, it might as well be: > >

[HACKERS] Redundant check of em_is_child

2017-05-19 Thread Amit Langote
In match_eclasses_to_foreign_key_col(), there is this: if (em->em_is_child) continue; /* ignore children here */ ISTM, it might as well be: Assert(!em->em_is_child);/* no children yet */ That's because, I think it's still too early in