Re: [HACKERS] Refectoring of receivelog.c

2016-03-13 Thread Magnus Hagander
On Sun, Mar 13, 2016 at 12:15 AM, Tomas Vondra wrote: > On 03/11/2016 11:15 AM, Magnus Hagander wrote: > >> >> ... > >> >> >> Pushed with updated comments and a named stsruct. >> > > Pretty sure this memset call in pg_basebackup.c is incorrect, as it passes >

Re: [HACKERS] Refectoring of receivelog.c

2016-03-12 Thread Tomas Vondra
On 03/11/2016 11:15 AM, Magnus Hagander wrote: ... Pushed with updated comments and a named stsruct. Pretty sure this memset call in pg_basebackup.c is incorrect, as it passes parameters in the wrong order: MemSet(, sizeof(stream), 0); It seems benign, because we're setting all

Re: [HACKERS] Refectoring of receivelog.c

2016-03-11 Thread Magnus Hagander
On Fri, Mar 11, 2016 at 9:40 AM, Daniel Gustafsson wrote: > > On 15 Feb 2016, at 14:46, Magnus Hagander wrote: > > > > On Mon, Feb 15, 2016 at 7:15 AM, Craig Ringer > wrote: > > On 15 February 2016 at

Re: [HACKERS] Refectoring of receivelog.c

2016-03-11 Thread Daniel Gustafsson
> On 15 Feb 2016, at 14:46, Magnus Hagander wrote: > > On Mon, Feb 15, 2016 at 7:15 AM, Craig Ringer > wrote: > On 15 February 2016 at 04:48, Magnus Hagander > wrote:

Re: [HACKERS] Refectoring of receivelog.c

2016-02-15 Thread Magnus Hagander
On Mon, Feb 15, 2016 at 7:15 AM, Craig Ringer wrote: > On 15 February 2016 at 04:48, Magnus Hagander wrote: > >> I was working on adding the tar streaming functionality we talked about >> at the developer meeting to pg_basebackup, and rapidly ran

Re: [HACKERS] Refectoring of receivelog.c

2016-02-14 Thread Craig Ringer
On 15 February 2016 at 04:48, Magnus Hagander wrote: > I was working on adding the tar streaming functionality we talked about at > the developer meeting to pg_basebackup, and rapidly ran across the issue > that Andres has been complaining about for a while. The code in >

[HACKERS] Refectoring of receivelog.c

2016-02-14 Thread Magnus Hagander
I was working on adding the tar streaming functionality we talked about at the developer meeting to pg_basebackup, and rapidly ran across the issue that Andres has been complaining about for a while. The code in receivelog.c just passes an insane number of parameters around. Adding or changing