Re: [HACKERS] Removal of useless include references

2011-09-01 Thread Bruce Momjian
Bruce Momjian wrote: Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian br...@momjian.us writes: It has been years since I ran src/tools/pginclude/pgrminclude to remove unnecessary include files. (I have already fixed things so include files can be compiled on their own.)

Re: [HACKERS] Removal of useless include references

2011-09-01 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of jue sep 01 11:04:33 -0300 2011: Bruce Momjian wrote: OK, try #2. I already had code that removed #if/#else/#endif code in *.h files for better testing, so I extended that to all *.c files. This reduces the size of the diff from 6.6k lines to 4.7k

Re: [HACKERS] Removal of useless include references

2011-09-01 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Bruce Momjian's message of jue sep 01 11:04:33 -0300 2011: I have re-run the script and applied the result, again tested on BSD and Linux. I will monitor the buildfarm for possible failures. I think anything of this sort should

Re: [HACKERS] Removal of useless include references

2011-09-01 Thread Bruce Momjian
Alvaro Herrera wrote: Excerpts from Bruce Momjian's message of jue sep 01 11:04:33 -0300 2011: Bruce Momjian wrote: OK, try #2. I already had code that removed #if/#else/#endif code in *.h files for better testing, so I extended that to all *.c files. This reduces the size of the

Re: [HACKERS] Removal of useless include references

2011-09-01 Thread Bruce Momjian
Tom Lane wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Bruce Momjian's message of jue sep 01 11:04:33 -0300 2011: I have re-run the script and applied the result, again tested on BSD and Linux. I will monitor the buildfarm for possible failures. I think

Re: [HACKERS] Removal of useless include references

2011-08-26 Thread Christian Ullrich
* Bruce Momjian wrote: The attached patch removes unneeded include references, and marks some includes as needing to be skipped by pgrminclude. There are several unrelated changes to pg_upgrade in that patch, too. -- Christian -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Removal of useless include references

2011-08-26 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: It has been years since I ran src/tools/pginclude/pgrminclude to remove unnecessary include files. (I have already fixed things so include files can be compiled on their own.) The attached patch removes unneeded include references,

Re: [HACKERS] Removal of useless include references

2011-08-26 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of vie ago 26 01:35:45 -0300 2011: It has been years since I ran src/tools/pginclude/pgrminclude to remove unnecessary include files. (I have already fixed things so include files can be compiled on their own.) The attached patch removes unneeded

Re: [HACKERS] Removal of useless include references

2011-08-26 Thread Bruce Momjian
Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian br...@momjian.us writes: It has been years since I ran src/tools/pginclude/pgrminclude to remove unnecessary include files. (I have already fixed things so include files can be compiled on their own.) The attached patch removes

Re: [HACKERS] Removal of useless include references

2011-08-26 Thread Bruce Momjian
Alvaro Herrera wrote: Excerpts from Bruce Momjian's message of vie ago 26 01:35:45 -0300 2011: It has been years since I ran src/tools/pginclude/pgrminclude to remove unnecessary include files. (I have already fixed things so include files can be compiled on their own.) The attached

Re: [HACKERS] Removal of useless include references

2011-08-25 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: It has been years since I ran src/tools/pginclude/pgrminclude to remove unnecessary include files. (I have already fixed things so include files can be compiled on their own.) The attached patch removes unneeded include references, and marks some