Re: [HACKERS] Request for review: tsearch2 patch

2007-01-12 Thread Teodor Sigaev
Yeah, it's a workaround. Since there's no concept other than alpha/numeric/latin in tsearch2, Asian characters have to be fall in one of them. Ok, I see. Pls, test attached patch - if it is good then I'll commit it at Monday to HEAD and 8.2 branches. PS. Magnus, may I ask you to test under

Re: [HACKERS] Request for review: tsearch2 patch

2007-01-12 Thread Tatsuo Ishii
Yeah, it's a workaround. Since there's no concept other than alpha/numeric/latin in tsearch2, Asian characters have to be fall in one of them. Ok, I see. Pls, test attached patch - if it is good then I'll commit it at Monday to HEAD and 8.2 branches. I have tested on a Linux box

Re: [HACKERS] Request for review: tsearch2 patch

2007-01-10 Thread Teodor Sigaev
Sorry for delay, I was on holidays :) Did you test patch on Windows platform? Tatsuo Ishii wrote: I have tested with local-enabled environment and found a bug. Included is the new version of patches. Teodor, Oleg, what do you think about these patches? If ok, shall I commit to CVS head? --

Re: [HACKERS] Request for review: tsearch2 patch

2007-01-10 Thread Tatsuo Ishii
Sorry for delay, I was on holidays :) Did you test patch on Windows platform? No. I myself does not use Windows platform. Do you have any concern on Windows regarding my patches? -- Tatsuo Ishii SRA OSS, Inc. Japan Tatsuo Ishii wrote: I have tested with local-enabled environment and

Re: [HACKERS] Request for review: tsearch2 patch

2007-01-10 Thread Tatsuo Ishii
From: Teodor Sigaev [EMAIL PROTECTED] Subject: Re: [HACKERS] Request for review: tsearch2 patch Date: Wed, 10 Jan 2007 18:50:44 +0300 Message-ID: [EMAIL PROTECTED] I have tested with local-enabled environment and found a bug. Included is the new version of patches. Your patch causes crash

Re: [HACKERS] Request for review: tsearch2 patch

2007-01-10 Thread Tatsuo Ishii
I have tested with local-enabled environment and found a bug. Included is the new version of patches. Your patch causes crash on tsearch2's installcheck with 'initdb -E UTF8 --locale C', simple way to reproduce: # select to_tsquery('default', '''New York'''); server closed the

Re: [HACKERS] Request for review: tsearch2 patch

2007-01-04 Thread Tatsuo Ishii
I have tested with local-enabled environment and found a bug. Included is the new version of patches. Teodor, Oleg, what do you think about these patches? If ok, shall I commit to CVS head? -- Tatsuo Ishii SRA OSS, Inc. Japan Hi, Here are patches against tsearch2 with CVS head. Currently

[HACKERS] Request for review: tsearch2 patch

2007-01-01 Thread Tatsuo Ishii
Hi, Here are patches against tsearch2 with CVS head. Currently tsearch2 does not work with multibyte encoding which uses C locale. These patches are intended to solve the problem by using PostgreSQL in-house multibyte function instead of mbstowcs which does not work with C locale. Also iswalpha