On Sat, Oct 10, 2009 at 2:09 PM, Boszormenyi Zoltan wrote:
> Michael Meskes írta:
>> On Thu, Oct 08, 2009 at 01:15:58PM +0200, Boszormenyi Zoltan wrote:
>>
What's the point of that? It can't be applied without documentation,
and it just makes life more complicated to have two separate p
Michael Meskes írta:
> On Thu, Oct 08, 2009 at 01:15:58PM +0200, Boszormenyi Zoltan wrote:
>
>>> What's the point of that? It can't be applied without documentation,
>>> and it just makes life more complicated to have two separate patch
>>> files floating around.
>>>
>> It's easier to wr
On Thu, Oct 08, 2009 at 01:15:58PM +0200, Boszormenyi Zoltan wrote:
> > What's the point of that? It can't be applied without documentation,
> > and it just makes life more complicated to have two separate patch
> > files floating around.
> It's easier to write the documentation for all changes at
Robert Haas writes:
> I have not looked at your patches and am not familiar with ECPG, but I
> wonder if part of the issue here is that there are too many
> interrelated changes. Maybe you'd be better off submitting some
> smaller changes, wait to see how they get committed, and then move on
> to
On Thu, Oct 8, 2009 at 7:15 AM, Boszormenyi Zoltan wrote:
> It's easier to write the documentation for all changes at once.
> I would have the same situation that happened with the code,
> the patches with the documentation added would strictly depend
> on each other again. Also, Michael Meskes ap
Robert Haas írta:
> On Thu, Oct 8, 2009 at 6:22 AM, Boszormenyi Zoltan wrote:
>
>> Noah Misch írta:
>>
>>> I will report on the sqlda patch in more detail on
>>> 2009-10-10.
>>>
>> I am attaching a new one, please review this. Changes:
>> - set sqllen, sqlind, sqlilen and sqlitype p
On Thu, Oct 8, 2009 at 6:22 AM, Boszormenyi Zoltan wrote:
> Noah Misch írta:
>> I will report on the sqlda patch in more detail on
>> 2009-10-10.
>
> I am attaching a new one, please review this. Changes:
> - set sqllen, sqlind, sqlilen and sqlitype per-field properties
> - SQLINT8 and SQLSERIAL8
On Mon, Oct 05, 2009 at 02:23:57PM +0200, Boszormenyi Zoltan wrote:
> Noah Misch ?rta:
> I will post a new patch for SQLDA and for all others that need
> updating.
Thanks; that one does apply cleanly.
> > The main test suite acquired no regressions, but I get failures in two
> > tests of
> > th
Hi,
thank you very much for the review.
Noah Misch írta:
> I took a look at 2-pg85-sqlda-10-ctxdiff.patch. Starting from CVS HEAD of
> roughly 2009-10-03 05:00 UTC, prerequisite patches 1a-1h applied cleanly.
> 2-pg85-sqlda hit a trivial whitespace reject in ecpg.trailer along with a more
> subs
I took a look at 2-pg85-sqlda-10-ctxdiff.patch. Starting from CVS HEAD of
roughly 2009-10-03 05:00 UTC, prerequisite patches 1a-1h applied cleanly.
2-pg85-sqlda hit a trivial whitespace reject in ecpg.trailer along with a more
substantive reject at ecpg.addons:407 (FetchStmtMOVEfetch_args). Fixin
10 matches
Mail list logo