Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-10 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I have cleaned up the contrib install/uninstall to be more consistent, > > used CREATE OR REPLACE function consisently, and removed transaction > > blocks. > > ... and broken the buildfarm ... OK, fixed, thanks. -- Bruce Momjian

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-10 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I have cleaned up the contrib install/uninstall to be more consistent, > used CREATE OR REPLACE function consisently, and removed transaction > blocks. ... and broken the buildfarm ... regards, tom lane -

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-10 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > "Marko Kreen" <[EMAIL PROTECTED]> writes: > > > On 11/10/07, Bruce Momjian <[EMAIL PROTECTED]> wrote: > > >> OK, first question. How would someone have the 8.0 signatures in 8.2? > > >> Don't they reinstall pgcrypto for every major release? > > > > > Why

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-10 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> If you don't re-run a contrib module's sql script then you don't get any > >> new functions that may have been added to the module. So I think the > >> real issue here is that we ought to deprecate the idea of ski

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-09 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> If you don't re-run a contrib module's sql script then you don't get any >> new functions that may have been added to the module. So I think the >> real issue here is that we ought to deprecate the idea of skipping that >> step, period

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-09 Thread Bruce Momjian
Tom Lane wrote: > "Marko Kreen" <[EMAIL PROTECTED]> writes: > > On 11/10/07, Bruce Momjian <[EMAIL PROTECTED]> wrote: > >> OK, first question. How would someone have the 8.0 signatures in 8.2? > >> Don't they reinstall pgcrypto for every major release? > > > Why reinstall if the functions come fr

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-09 Thread Bruce Momjian
Marko Kreen wrote: > On 11/10/07, Bruce Momjian <[EMAIL PROTECTED]> wrote: > > OK, first question. How would someone have the 8.0 signatures in 8.2? > > Don't they reinstall pgcrypto for every major release? > > Why reinstall if the functions come from dump? > > At least in skype we stumbled on

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-09 Thread Tom Lane
"Marko Kreen" <[EMAIL PROTECTED]> writes: > On 11/10/07, Bruce Momjian <[EMAIL PROTECTED]> wrote: >> OK, first question. How would someone have the 8.0 signatures in 8.2? >> Don't they reinstall pgcrypto for every major release? > Why reinstall if the functions come from dump? > At least in skyp

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-09 Thread Marko Kreen
On 11/10/07, Bruce Momjian <[EMAIL PROTECTED]> wrote: > OK, first question. How would someone have the 8.0 signatures in 8.2? > Don't they reinstall pgcrypto for every major release? Why reinstall if the functions come from dump? At least in skype we stumbled on the problem. But if the reinstal

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-09 Thread Bruce Momjian
Marko Kreen wrote: > On 11/7/07, Bruce Momjian <[EMAIL PROTECTED]> wrote: > > OK, should we add a mention in the 8.2.6 release notes or put it in the > > 8. notes and figure if someone is upgrading they will read the 8.2 > > notes? What would the description be? > > """ > Note about pgcrypto - th

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-09 Thread Marko Kreen
On 11/7/07, Bruce Momjian <[EMAIL PROTECTED]> wrote: > OK, should we add a mention in the 8.2.6 release notes or put it in the > 8. notes and figure if someone is upgrading they will read the 8.2 > notes? What would the description be? """ Note about pgcrypto - the functions were made STRICT in 8

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-07 Thread Bruce Momjian
Marko Kreen wrote: > On 11/6/07, Bruce Momjian <[EMAIL PROTECTED]> wrote: > > Alvaro Herrera wrote: > > > > > Tom, how about putting a note about that into next 8.2 minor > > > > > release notes? (8.3 too?) Something like "You need to refresh > > > > > pgcrypto functions, because since rel 8.2 th

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-06 Thread Marko Kreen
On 11/6/07, Bruce Momjian <[EMAIL PROTECTED]> wrote: > Alvaro Herrera wrote: > > > > Tom, how about putting a note about that into next 8.2 minor > > > > release notes? (8.3 too?) Something like "You need to refresh > > > > pgcrypto functions, because since rel 8.2 the code depends > > > > on fun

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-05 Thread Bruce Momjian
Alvaro Herrera wrote: > > > > If something is not going a work (or is going a work in a different > > > > way) in some version after loading a shot form a previous one I think > > > > it should be documented or some kind of backwards compatibility > > > > mechanism should be provided. > > > > > >

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-05 Thread Alvaro Herrera
Bruce Momjian wrote: > Marko Kreen wrote: > > On 8/24/07, Manuel Sugawara <[EMAIL PROTECTED]> wrote: > > > If something is not going a work (or is going a work in a different > > > way) in some version after loading a shot form a previous one I think > > > it should be documented or some kind of b

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-11-04 Thread Bruce Momjian
Marko Kreen wrote: > On 8/24/07, Manuel Sugawara <[EMAIL PROTECTED]> wrote: > > Tom Lane <[EMAIL PROTECTED]> writes: > > > Manuel Sugawara <[EMAIL PROTECTED]> writes: > > >> "Marko Kreen" <[EMAIL PROTECTED]> writes: > > >>> In 8.0 the pgcrypto functions were non-strict and checked for NULLs. > > >>

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-08-27 Thread Marko Kreen
On 8/24/07, Manuel Sugawara <[EMAIL PROTECTED]> wrote: > Tom Lane <[EMAIL PROTECTED]> writes: > > Manuel Sugawara <[EMAIL PROTECTED]> writes: > >> "Marko Kreen" <[EMAIL PROTECTED]> writes: > >>> In 8.0 the pgcrypto functions were non-strict and checked for NULLs. > >>> In 8.1 they were made STRICT.

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-08-24 Thread Manuel Sugawara
Tom Lane <[EMAIL PROTECTED]> writes: > Manuel Sugawara <[EMAIL PROTECTED]> writes: >> "Marko Kreen" <[EMAIL PROTECTED]> writes: >>> In 8.0 the pgcrypto functions were non-strict and checked for NULLs. >>> In 8.1 they were made STRICT. >>> In 8.2 the NULL check were removed from code. > >> Not an s

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-08-24 Thread Tom Lane
Manuel Sugawara <[EMAIL PROTECTED]> writes: > "Marko Kreen" <[EMAIL PROTECTED]> writes: >> In 8.0 the pgcrypto functions were non-strict and checked for NULLs. >> In 8.1 they were made STRICT. >> In 8.2 the NULL check were removed from code. > Not an smart move IMHO, I didn't create the function,

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-08-24 Thread Manuel Sugawara
"Marko Kreen" <[EMAIL PROTECTED]> writes: > On 8/24/07, Manuel Sugawara <[EMAIL PROTECTED]> wrote: >> Manuel Sugawara <[EMAIL PROTECTED]> writes: >> > I have a simple query that uses digest(data, 'sha1') and consistently >> > crashes the backend >> >> The problem is with null arguments: >> >> cien

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-08-24 Thread Richard Huxton
Manuel Sugawara wrote: I have a simple query that uses digest(data, 'sha1') and consistently crashes the backend The problem is with null arguments: ciencias=# select digest(null, 'sha1'); el servidor ha cerrado la conexión inesperadamente, Can you check if the function is defined "STRICT"?

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-08-24 Thread Marko Kreen
On 8/24/07, Manuel Sugawara <[EMAIL PROTECTED]> wrote: > Manuel Sugawara <[EMAIL PROTECTED]> writes: > > I have a simple query that uses digest(data, 'sha1') and consistently > > crashes the backend > > The problem is with null arguments: > > ciencias=# select digest(null, 'sha1'); In 8.0 the pgcr

Re: [HACKERS] Segmentation fault using digest from pg_crypto

2007-08-23 Thread Manuel Sugawara
Manuel Sugawara <[EMAIL PROTECTED]> writes: > Hi, > > I have a simple query that uses digest(data, 'sha1') and consistently > crashes the backend The problem is with null arguments: ciencias=# select digest(null, 'sha1'); el servidor ha cerrado la conexión inesperadamente, probablemente

[HACKERS] Segmentation fault using digest from pg_crypto

2007-08-23 Thread Manuel Sugawara
Hi, I have a simple query that uses digest(data, 'sha1') and consistently crashes the backend (tested in two different machines): ciencias=# select version(); version -