Re: [HACKERS] Server Crashes if try to provide slot_name='none' at the time of creating subscription.

2017-05-17 Thread Masahiko Sawada
On Thu, May 18, 2017 at 10:33 AM, Peter Eisentraut wrote: > On 5/16/17 22:21, Masahiko Sawada wrote: >> I think there are two bugs; pg_dump should dump slot_name = NONE >> instead of '' and subscription should not be created if given slot >> name is invalid. The

Re: [HACKERS] Server Crashes if try to provide slot_name='none' at the time of creating subscription.

2017-05-17 Thread Peter Eisentraut
On 5/16/17 22:21, Masahiko Sawada wrote: > I think there are two bugs; pg_dump should dump slot_name = NONE > instead of '' and subscription should not be created if given slot > name is invalid. The validation check for replication slot name is > done when creating it actually but I think it's

Re: [HACKERS] Server Crashes if try to provide slot_name='none' at the time of creating subscription.

2017-05-16 Thread Masahiko Sawada
On Tue, May 16, 2017 at 10:06 PM, tushar wrote: > On 05/16/2017 06:35 AM, Masahiko Sawada wrote: >> >> I've updated Kuntal's patch, added regression test for option >> combination and updated documentation. > > While testing the patch - I found that after

Re: [HACKERS] Server Crashes if try to provide slot_name='none' at the time of creating subscription.

2017-05-16 Thread tushar
On 05/16/2017 06:35 AM, Masahiko Sawada wrote: I've updated Kuntal's patch, added regression test for option combination and updated documentation. While testing the patch - I found that after dump/restore , we are getting an error in the log file once we enable the subscription \\create

Re: [HACKERS] Server Crashes if try to provide slot_name='none' at the time of creating subscription.

2017-05-16 Thread Kuntal Ghosh
Added to open item lists. On Tue, May 16, 2017 at 6:35 AM, Masahiko Sawada wrote: > On Mon, May 15, 2017 at 8:09 PM, Masahiko Sawada > wrote: >> On Mon, May 15, 2017 at 8:06 PM, Kuntal Ghosh >> wrote: >>> On Mon, May

Re: [HACKERS] Server Crashes if try to provide slot_name='none' at the time of creating subscription.

2017-05-15 Thread Masahiko Sawada
On Mon, May 15, 2017 at 8:09 PM, Masahiko Sawada wrote: > On Mon, May 15, 2017 at 8:06 PM, Kuntal Ghosh > wrote: >> On Mon, May 15, 2017 at 4:00 PM, Masahiko Sawada >> wrote: >>> On Mon, May 15, 2017 at 6:41 PM, tushar

Re: [HACKERS] Server Crashes if try to provide slot_name='none' at the time of creating subscription.

2017-05-15 Thread Kuntal Ghosh
On Mon, May 15, 2017 at 5:04 PM, Masahiko Sawada wrote: > On Mon, May 15, 2017 at 8:22 PM, Kuntal Ghosh > wrote: >> On Mon, May 15, 2017 at 4:39 PM, Masahiko Sawada >> wrote: >> >> While testing with logical replication,

Re: [HACKERS] Server Crashes if try to provide slot_name='none' at the time of creating subscription.

2017-05-15 Thread Masahiko Sawada
On Mon, May 15, 2017 at 8:22 PM, Kuntal Ghosh wrote: > On Mon, May 15, 2017 at 4:39 PM, Masahiko Sawada > wrote: > > While testing with logical replication, I've found that the server > hangs if we create a subscription to the same server. For

Re: [HACKERS] Server Crashes if try to provide slot_name='none' at the time of creating subscription.

2017-05-15 Thread Kuntal Ghosh
On Mon, May 15, 2017 at 4:39 PM, Masahiko Sawada wrote: While testing with logical replication, I've found that the server hangs if we create a subscription to the same server. For example, $ ./pg_ctl -D Test start -o "-p 5432" $ ./psql -p 5432 postgres -c "CREATE

Re: [HACKERS] Server Crashes if try to provide slot_name='none' at the time of creating subscription.

2017-05-15 Thread Masahiko Sawada
On Mon, May 15, 2017 at 8:06 PM, Kuntal Ghosh wrote: > On Mon, May 15, 2017 at 4:00 PM, Masahiko Sawada > wrote: >> On Mon, May 15, 2017 at 6:41 PM, tushar >> wrote: >>> Hi, >>> >>> Server Crashes if we try to

Re: [HACKERS] Server Crashes if try to provide slot_name='none' at the time of creating subscription.

2017-05-15 Thread Kuntal Ghosh
On Mon, May 15, 2017 at 4:00 PM, Masahiko Sawada wrote: > On Mon, May 15, 2017 at 6:41 PM, tushar wrote: >> Hi, >> >> Server Crashes if we try to provide slot_name='none' at the time of creating >> subscription - >> >> postgres=# create

Re: [HACKERS] Server Crashes if try to provide slot_name='none' at the time of creating subscription.

2017-05-15 Thread Masahiko Sawada
On Mon, May 15, 2017 at 6:41 PM, tushar wrote: > Hi, > > Server Crashes if we try to provide slot_name='none' at the time of creating > subscription - > > postgres=# create subscription sub2 connection 'dbname=postgres port=5000 > user=centos password=f'

[HACKERS] Server Crashes if try to provide slot_name='none' at the time of creating subscription.

2017-05-15 Thread tushar
Hi, Server Crashes if we try to provide slot_name='none' at the time of creating subscription - postgres=# create subscription sub2 connection 'dbname=postgres port=5000 user=centos password=f' publication abc with (slot_name='none'); NOTICE: synchronized table states server closed the