Re: [HACKERS] Should we add crc32 in libpgport?

2012-02-28 Thread Tom Lane
Daniel Farina dan...@heroku.com writes: Thinking unnecessary. Motion is progress. Here is a patch that uses this exact plan: pgport for the tables, broken out into a header file that is included in the building of libpgport. I have confirmed by objdump -t that multiple copies of the table

Re: [HACKERS] Should we add crc32 in libpgport?

2012-02-22 Thread Daniel Farina
On Thu, Feb 16, 2012 at 6:09 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Feb 3, 2012 at 7:33 PM, Daniel Farina dan...@heroku.com wrote: Ah, yes, I think my optimizations were off when building, or something.  I didn't get such verbosity at first, and then I remember doing something

Re: [HACKERS] Should we add crc32 in libpgport?

2012-02-16 Thread Robert Haas
On Fri, Feb 3, 2012 at 7:33 PM, Daniel Farina dan...@heroku.com wrote: Ah, yes, I think my optimizations were off when building, or something.  I didn't get such verbosity at first, and then I remember doing something slightly different and then getting a lot of output. I didn't pay attention

Re: [HACKERS] Should we add crc32 in libpgport?

2012-02-03 Thread Daniel Farina
On Tue, Jan 31, 2012 at 3:43 PM, Tom Lane t...@sss.pgh.pa.us wrote: Daniel Farina dan...@heroku.com writes: On Tue, Jan 17, 2012 at 2:14 AM, Daniel Farina dan...@heroku.com wrote: See the attached patch.  It has a detailed cover letter/comment at the top of the file. I have amended that

Re: [HACKERS] Should we add crc32 in libpgport?

2012-01-31 Thread Tom Lane
Daniel Farina dan...@heroku.com writes: On Tue, Jan 17, 2012 at 2:14 AM, Daniel Farina dan...@heroku.com wrote: See the attached patch.  It has a detailed cover letter/comment at the top of the file. I have amended that description to be more accurate. I looked at this a bit, and it seems to

Re: [HACKERS] Should we add crc32 in libpgport?

2012-01-26 Thread Abhijit Menon-Sen
At 2012-01-17 13:43:11 -0800, dan...@heroku.com wrote: See the attached patch.  It has a detailed cover letter/comment at the top of the file. The patch looks good, but the resetxlog and controldata Makefile hunks didn't apply. I don't know why, but I've attached updated versions of those

[HACKERS] Should we add crc32 in libpgport?

2012-01-16 Thread Daniel Farina
I have been working with xlogdump and noticed that unfortunately it cannot be installed without access to a postgres build directory, which makes the exported functionality in src/include/utils/pg_crc.h useless unless one has access to pg_crc.o -- which would only happen if a build directory is

Re: [HACKERS] Should we add crc32 in libpgport?

2012-01-16 Thread Daniel Farina
On Mon, Jan 16, 2012 at 4:56 PM, Daniel Farina dan...@heroku.com wrote: I have been working with xlogdump and noticed that unfortunately it cannot be installed without access to a postgres build directory, which makes the exported functionality in src/include/utils/pg_crc.h useless unless one

Re: [HACKERS] Should we add crc32 in libpgport?

2012-01-16 Thread Robert Haas
On Mon, Jan 16, 2012 at 8:09 PM, Daniel Farina dan...@heroku.com wrote: On Mon, Jan 16, 2012 at 4:56 PM, Daniel Farina dan...@heroku.com wrote: I have been working with xlogdump and noticed that unfortunately it cannot be installed without access to a postgres build directory, which makes the

Re: [HACKERS] Should we add crc32 in libpgport?

2012-01-16 Thread Daniel Farina
On Mon, Jan 16, 2012 at 6:18 PM, Robert Haas robertmh...@gmail.com wrote: I think you make a compelling case. That's enough for me to just do it. Expect a patch soon. -- fdr -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Should we add crc32 in libpgport?

2012-01-16 Thread Tom Lane
Daniel Farina dan...@heroku.com writes: Copying CRC32 implementations everywhere is not the worst thing, but I find it inadequately explained why it's necessary for now, at least. Agreed, but I don't care for your proposed solution (put it in libpgport) because that assumes a fact not in