On Thu, Oct 23, 2014 at 10:45 AM, Peter Eisentraut pete...@gmx.net wrote:
Committed your patch and tests.
Thanks!
--
Michael
On 10/21/14 6:19 PM, Michael Paquier wrote:
On Wed, Oct 22, 2014 at 5:03 AM, Peter Eisentraut pete...@gmx.net
mailto:pete...@gmx.net wrote:
While looking at this, I wrote a few tests cases for sequence
privileges, because that was not covered at all. That patch is
attached.
On 8/27/14 8:02 AM, Michael Paquier wrote:
In a couple of code paths we do the following to check permissions on an
object:
if (pg_class_aclcheck(relid, userid, ACL_USAGE) != ACLCHECK_OK
pg_class_aclcheck(relid, userid, ACL_UPDATE) != ACLCHECK_OK)
ereport(ERROR, blah);
Wouldn't it
On Wed, Oct 22, 2014 at 5:03 AM, Peter Eisentraut pete...@gmx.net wrote:
While looking at this, I wrote a few tests cases for sequence
privileges, because that was not covered at all. That patch is attached.
+1 for those tests.
--
Michael
Em terça-feira, 21 de outubro de 2014, Michael Paquier
michael.paqu...@gmail.com escreveu:
On Wed, Oct 22, 2014 at 5:03 AM, Peter Eisentraut pete...@gmx.net
javascript:_e(%7B%7D,'cvml','pete...@gmx.net'); wrote:
While looking at this, I wrote a few tests cases for sequence
privileges,
On Wed, Aug 27, 2014 at 9:02 AM, Michael Paquier michael.paqu...@gmail.com
wrote:
Hi all,
In a couple of code paths we do the following to check permissions on an
object:
if (pg_class_aclcheck(relid, userid, ACL_USAGE) != ACLCHECK_OK
pg_class_aclcheck(relid, userid, ACL_UPDATE) !=
Hi all,
In a couple of code paths we do the following to check permissions on an
object:
if (pg_class_aclcheck(relid, userid, ACL_USAGE) != ACLCHECK_OK
pg_class_aclcheck(relid, userid, ACL_UPDATE) != ACLCHECK_OK)
ereport(ERROR, blah);
Wouldn't it be better to simplify that with a single
