Re: [HACKERS] Small doc patch about pg_service.conf

2015-02-02 Thread Magnus Hagander
On Sun, Feb 1, 2015 at 9:14 PM, Noah Misch n...@leadboat.com wrote: On Sun, Feb 01, 2015 at 10:50:24AM -0500, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: At least writing `pg_config --sysconfdir` indicates that it's in an installation-specific location, whereas hardcoding

Re: [HACKERS] Small doc patch about pg_service.conf

2015-02-01 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: At least writing `pg_config --sysconfdir` indicates that it's in an installation-specific location, whereas hardcoding /etc will create confusion when it's not actually there. (Incidentally, we use /usr/local/pgsql/etc elsewhere in the documentation as

Re: [HACKERS] Small doc patch about pg_service.conf

2015-02-01 Thread Noah Misch
On Sun, Feb 01, 2015 at 10:50:24AM -0500, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: At least writing `pg_config --sysconfdir` indicates that it's in an installation-specific location, whereas hardcoding /etc will create confusion when it's not actually there. (Incidentally,

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-31 Thread Peter Eisentraut
On 1/3/15 7:56 PM, Tom Lane wrote: Noah Misch n...@leadboat.com writes: On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: The directory libpq consults is `pg_config --sysconfdir` I was wrong there. `pg_config --sysconfig` uses get_etc_path(), which adjusts to post-installation

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Magnus Hagander
On Wed, Dec 31, 2014 at 3:24 PM, David Fetter da...@fetter.org wrote: Folks, There was a slash missing, which I've added. Where is the default directory on Windows, or is there one? Applied, thanks. And - from a quick check, it looks like it's actually using /etc on Windows as well. Which

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread David Fetter
On Sat, Jan 03, 2015 at 03:03:45PM -0500, Tom Lane wrote: David Fetter da...@fetter.org writes: On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: The old and the new documentation are both wrong. The directory libpq consults is `pg_config --sysconfdir`, which is packager-selected

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread David Fetter
On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: On Sat, Jan 03, 2015 at 01:22:02PM +0100, Magnus Hagander wrote: On Wed, Dec 31, 2014 at 3:24 PM, David Fetter da...@fetter.org wrote: There was a slash missing, which I've added. Where is the default directory on Windows, or is

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread David Fetter
On Sat, Jan 03, 2015 at 01:22:02PM +0100, Magnus Hagander wrote: On Wed, Dec 31, 2014 at 3:24 PM, David Fetter da...@fetter.org wrote: Folks, There was a slash missing, which I've added. Where is the default directory on Windows, or is there one? Applied, thanks. Thank you. And

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Tom Lane
David Fetter da...@fetter.org writes: On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: The old and the new documentation are both wrong. The directory libpq consults is `pg_config --sysconfdir`, which is packager-selected but rarely matches /etc itself. parseServiceInfo() has the

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Noah Misch
On Sat, Jan 03, 2015 at 01:22:02PM +0100, Magnus Hagander wrote: On Wed, Dec 31, 2014 at 3:24 PM, David Fetter da...@fetter.org wrote: There was a slash missing, which I've added. Where is the default directory on Windows, or is there one? Applied, thanks. The old and the new

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Magnus Hagander
On Sat, Jan 3, 2015 at 9:03 PM, Tom Lane t...@sss.pgh.pa.us wrote: David Fetter da...@fetter.org writes: On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: The old and the new documentation are both wrong. The directory libpq consults is `pg_config --sysconfdir`, which is

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Andrew Dunstan
On 01/03/2015 04:41 PM, Magnus Hagander wrote: We could do worse than to say it's in the directory printed by pg_config --sysconfdir. Yeah. But let's make sure we include usually /etc or something like that. But it's not usually /etc. Certainly it's not in the PGDG RPM builds

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Magnus Hagander
On Sat, Jan 3, 2015 at 10:52 PM, Andrew Dunstan and...@dunslane.net wrote: On 01/03/2015 04:41 PM, Magnus Hagander wrote: We could do worse than to say it's in the directory printed by pg_config --sysconfdir. Yeah. But let's make sure we include usually /etc or something like

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Sat, Jan 3, 2015 at 10:52 PM, Andrew Dunstan and...@dunslane.net wrote: On 01/03/2015 04:41 PM, Magnus Hagander wrote: Yeah. But let's make sure we include usually /etc or something like that. But it's not usually /etc. Certainly it's not in the

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Noah Misch
On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: The directory libpq consults is `pg_config --sysconfdir` I was wrong there. `pg_config --sysconfig` uses get_etc_path(), which adjusts to post-installation moves of the installation tree. parseServiceInfo() uses the build-time

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Tom Lane
Noah Misch n...@leadboat.com writes: On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: The directory libpq consults is `pg_config --sysconfdir` I was wrong there. `pg_config --sysconfig` uses get_etc_path(), which adjusts to post-installation moves of the installation tree.

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Noah Misch
On Sat, Jan 03, 2015 at 07:56:06PM -0500, Tom Lane wrote: Noah Misch n...@leadboat.com writes: On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: The directory libpq consults is `pg_config --sysconfdir` I was wrong there. `pg_config --sysconfig` uses get_etc_path(), which

[HACKERS] Small doc patch about pg_service.conf

2014-12-31 Thread David Fetter
Folks, There was a slash missing, which I've added. Where is the default directory on Windows, or is there one? Cheers, David. -- David Fetter da...@fetter.org http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fet...@gmail.com