Re: [HACKERS] Small fix in pg_rewind (redundant declaration)

2015-12-17 Thread Michael Paquier
On Fri, Dec 18, 2015 at 10:22 AM, Tom Lane wrote: > Done. Thanks. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Small fix in pg_rewind (redundant declaration)

2015-12-17 Thread Tom Lane
Michael Paquier writes: > On Thu, Dec 17, 2015 at 9:23 PM, YUriy Zhuravlev > wrote: >> Hello hackers. >> I've stumbled upon a strange code. >> In src/bin/pg_rewind/datapagemap.h we decalre: >> extern void datapagemap_destroy(datapagemap_t *map); >> But nowhere is implemented. I think the declara

Re: [HACKERS] Small fix in pg_rewind (redundant declaration)

2015-12-17 Thread Michael Paquier
On Thu, Dec 17, 2015 at 9:23 PM, YUriy Zhuravlev wrote: > Hello hackers. > I've stumbled upon a strange code. > In src/bin/pg_rewind/datapagemap.h we decalre: > extern void datapagemap_destroy(datapagemap_t *map); > But nowhere is implemented. I think the declaration of this function must be > re

[HACKERS] Small fix in pg_rewind (redundant declaration)

2015-12-17 Thread YUriy Zhuravlev
Hello hackers. I've stumbled upon a strange code. In src/bin/pg_rewind/datapagemap.h we decalre: extern void datapagemap_destroy(datapagemap_t *map); But nowhere is implemented. I think the declaration of this function must be removed. I'm not sure that this trivial things needed patch. Thanks.