Re: [HACKERS] Something is broken in logical decoding with CLOBBER_CACHE_ALWAYS

2015-01-05 Thread Andres Freund
On 2015-01-04 21:54:40 +0100, Andres Freund wrote: On January 4, 2015 9:51:43 PM CET, Andrew Dunstan and...@dunslane.net wrote: On 12/15/2014 12:04 PM, Andres Freund wrote: I think the safest fix would be to defer catchup interrupt processing while you're in this mode. You don't really

Re: [HACKERS] Something is broken in logical decoding with CLOBBER_CACHE_ALWAYS

2015-01-04 Thread Andrew Dunstan
On 12/15/2014 12:04 PM, Andres Freund wrote: I think the safest fix would be to defer catchup interrupt processing while you're in this mode. You don't really want to be processing any remote sinval messages at all, I'd think. Well, we need to do relmap, smgr and similar things. So I think

Re: [HACKERS] Something is broken in logical decoding with CLOBBER_CACHE_ALWAYS

2015-01-04 Thread Andres Freund
On January 4, 2015 9:51:43 PM CET, Andrew Dunstan and...@dunslane.net wrote: On 12/15/2014 12:04 PM, Andres Freund wrote: I think the safest fix would be to defer catchup interrupt processing while you're in this mode. You don't really want to be processing any remote sinval messages at all,

[HACKERS] Something is broken in logical decoding with CLOBBER_CACHE_ALWAYS

2014-12-15 Thread Tom Lane
The CLOBBER_CACHE_ALWAYS buildfarm members occasionally fail in contrib/test_decoding with TRAP: FailedAssertion(!(((bool)((relation)-rd_refcnt == 0))), File: relcache.c, Line: 1981) for example here: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=markhordt=2014-12-14%2005%3A50%3A09 and

Re: [HACKERS] Something is broken in logical decoding with CLOBBER_CACHE_ALWAYS

2014-12-15 Thread Andres Freund
Hi, On 2014-12-15 10:15:30 -0500, Tom Lane wrote: The CLOBBER_CACHE_ALWAYS buildfarm members occasionally fail in contrib/test_decoding with TRAP: FailedAssertion(!(((bool)((relation)-rd_refcnt == 0))), File: relcache.c, Line: 1981) for example here:

Re: [HACKERS] Something is broken in logical decoding with CLOBBER_CACHE_ALWAYS

2014-12-15 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2014-12-15 10:15:30 -0500, Tom Lane wrote: The CLOBBER_CACHE_ALWAYS buildfarm members occasionally fail in contrib/test_decoding with TRAP: FailedAssertion(!(((bool)((relation)-rd_refcnt == 0))), File: relcache.c, Line: 1981) Without catchup

Re: [HACKERS] Something is broken in logical decoding with CLOBBER_CACHE_ALWAYS

2014-12-15 Thread Andres Freund
On 2014-12-15 11:30:40 -0500, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-12-15 10:15:30 -0500, Tom Lane wrote: The CLOBBER_CACHE_ALWAYS buildfarm members occasionally fail in contrib/test_decoding with TRAP: FailedAssertion(!(((bool)((relation)-rd_refcnt == 0))),