Re: [HACKERS] Streaming replication, some small issues

2009-12-11 Thread Fujii Masao
On Tue, Dec 8, 2009 at 5:30 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: - If a WAL file is not found in the master for some reason, standby goes into an infinite loop retrying it: ERROR:  could not read xlog records: FATAL:  could not open file

Re: [HACKERS] Streaming replication, some small issues

2009-12-09 Thread Fujii Masao
On Wed, Dec 9, 2009 at 10:51 AM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Dec 9, 2009 at 10:12 AM, Tom Lane t...@sss.pgh.pa.us wrote: Fujii Masao masao.fu...@gmail.com writes: Thought? Am I missing something? This seems terribly overdesigned.  Just emit a warning when you see the

[HACKERS] Streaming replication, some small issues

2009-12-08 Thread Heikki Linnakangas
A couple of small issues spotted while reviewing the streaming replication patch: - Because sentPtr is initialized to zeros, GetOldestWALSendPointer will return zero before a just-launched WAL sender has sent its first message. That can lead to WAL files that are still needed by another standby

Re: [HACKERS] Streaming replication, some small issues

2009-12-08 Thread Fujii Masao
On Tue, Dec 8, 2009 at 5:30 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: A couple of small issues spotted while reviewing the streaming replication patch: Thanks for the review! - Because sentPtr is initialized to zeros, GetOldestWALSendPointer will return zero before a

Re: [HACKERS] Streaming replication, some small issues

2009-12-08 Thread Greg Stark
On Tue, Dec 8, 2009 at 8:30 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: - It's possible to shut down master, change max_wal_senders to 0, restart and do an operation like CLUSTER which then skips WAL-logging. Then shutdown, change max_wal_senders back to non-zero. All this

Re: [HACKERS] Streaming replication, some small issues

2009-12-08 Thread Heikki Linnakangas
Greg Stark wrote: On Tue, Dec 8, 2009 at 8:30 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: - It's possible to shut down master, change max_wal_senders to 0, restart and do an operation like CLUSTER which then skips WAL-logging. Then shutdown, change max_wal_senders back

Re: [HACKERS] Streaming replication, some small issues

2009-12-08 Thread Fujii Masao
On Tue, Dec 8, 2009 at 9:05 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: I suspect we should have a WAL record to say unlogged operation performed here which a standby database would recognize and throw a large warning up. +1. Seems like a very simple solution. Sounds

Re: [HACKERS] Streaming replication, some small issues

2009-12-08 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: Thought? Am I missing something? This seems terribly overdesigned. Just emit a warning when you see the unlogged op record and have done. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] Streaming replication, some small issues

2009-12-08 Thread Fujii Masao
On Wed, Dec 9, 2009 at 10:12 AM, Tom Lane t...@sss.pgh.pa.us wrote: Fujii Masao masao.fu...@gmail.com writes: Thought? Am I missing something? This seems terribly overdesigned.  Just emit a warning when you see the unlogged op record and have done. Sounds quite simple. OK, I'll do so.