Re: [HACKERS] Subscription code improvements

2017-08-17 Thread Masahiko Sawada
On Thu, Aug 17, 2017 at 8:17 PM, Masahiko Sawada wrote: > On Thu, Aug 17, 2017 at 9:10 AM, Peter Eisentraut > wrote: >> On 8/8/17 05:58, Masahiko Sawada wrote: >>> Are you planning to work on remaining patches 0005 and 0006 that >>>

Re: [HACKERS] Subscription code improvements

2017-08-17 Thread Masahiko Sawada
On Thu, Aug 17, 2017 at 9:10 AM, Peter Eisentraut wrote: > On 8/8/17 05:58, Masahiko Sawada wrote: >> Are you planning to work on remaining patches 0005 and 0006 that >> improve the subscription codes in PG11 cycle? If not, I will take over >> them and work on

Re: [HACKERS] Subscription code improvements

2017-08-16 Thread Peter Eisentraut
On 8/8/17 05:58, Masahiko Sawada wrote: > Are you planning to work on remaining patches 0005 and 0006 that > improve the subscription codes in PG11 cycle? If not, I will take over > them and work on the next CF. Based on your assessment, the remaining patches were not required bug fixes. So I

Re: [HACKERS] Subscription code improvements

2017-08-08 Thread Masahiko Sawada
Petr, On Thu, Aug 3, 2017 at 5:24 AM, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> Alvaro Herrera writes: >> > I wish you'd stop splitting error message strings across multiple lines. >> > I've been trapped by a faulty grep not

Re: [HACKERS] Subscription code improvements

2017-08-07 Thread Masahiko Sawada
On Mon, Aug 7, 2017 at 10:22 PM, Peter Eisentraut wrote: > On 8/7/17 00:27, Masahiko Sawada wrote: However, even with this patch there is still an issue that NOTICE messages "removed subscription for table public.t1" can be appeared even if we

Re: [HACKERS] Subscription code improvements

2017-08-07 Thread Peter Eisentraut
On 8/7/17 00:27, Masahiko Sawada wrote: >>> However, even with this patch there is still an issue that NOTICE >>> messages "removed subscription for table public.t1" can be appeared >>> even if we rollback ALTER SUBSCRIPTION REFRESH command as I mentioned >>> on earlier thread. Since I think this

Re: [HACKERS] Subscription code improvements

2017-08-07 Thread Peter Eisentraut
On 8/7/17 00:32, Masahiko Sawada wrote: > On Sun, Aug 6, 2017 at 7:44 AM, Noah Misch wrote: >> On Wed, Aug 02, 2017 at 04:09:43PM -0400, Peter Eisentraut wrote: >>> On 8/1/17 00:17, Noah Misch wrote: The above-described topic is currently a PostgreSQL 10 open item. Peter,

Re: [HACKERS] Subscription code improvements

2017-08-06 Thread Masahiko Sawada
On Sun, Aug 6, 2017 at 7:44 AM, Noah Misch wrote: > On Wed, Aug 02, 2017 at 04:09:43PM -0400, Peter Eisentraut wrote: >> On 8/1/17 00:17, Noah Misch wrote: >> > The above-described topic is currently a PostgreSQL 10 open item. Peter, >> > since you committed the patch believed

Re: [HACKERS] Subscription code improvements

2017-08-06 Thread Masahiko Sawada
On Sat, Aug 5, 2017 at 10:29 AM, Peter Eisentraut wrote: > On 8/4/17 12:02, Masahiko Sawada wrote: >> To make ALTER SUBSCRIPTION REFRESH being transactional, I prefer >> Petr's proposal. Because it can make ALTER SUBSCRIPTION and DROP >> SUBSCRIPTION stop the

Re: [HACKERS] Subscription code improvements

2017-08-05 Thread Noah Misch
On Wed, Aug 02, 2017 at 04:09:43PM -0400, Peter Eisentraut wrote: > On 8/1/17 00:17, Noah Misch wrote: > > The above-described topic is currently a PostgreSQL 10 open item. Peter, > > since you committed the patch believed to have created it, you own this open > > item. If some other commit is

Re: [HACKERS] Subscription code improvements

2017-08-04 Thread Peter Eisentraut
On 8/4/17 12:02, Masahiko Sawada wrote: > To make ALTER SUBSCRIPTION REFRESH being transactional, I prefer > Petr's proposal. Because it can make ALTER SUBSCRIPTION and DROP > SUBSCRIPTION stop the table sync workers that are in progress of > copying data. I'm not sure killing table sync workers

Re: [HACKERS] Subscription code improvements

2017-08-04 Thread Masahiko Sawada
On Fri, Aug 4, 2017 at 2:17 AM, Peter Eisentraut wrote: > On 7/13/17 23:53, Masahiko Sawada wrote: >> To summary, I think we now have only one issue; ALTER SUBSCRIPTION is >> not transactional, 0004 patch is addressing this issue . > > We have two competing

Re: [HACKERS] Subscription code improvements

2017-08-03 Thread Peter Eisentraut
On 7/13/17 23:53, Masahiko Sawada wrote: > To summary, I think we now have only one issue; ALTER SUBSCRIPTION is > not transactional, 0004 patch is addressing this issue . We have two competing patches for this issue. This patch moves the killing to the end of the DDL transaction. Your earlier

Re: [HACKERS] Subscription code improvements

2017-08-02 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Alvaro Herrera writes: > > I wish you'd stop splitting error message strings across multiple lines. > > I've been trapped by a faulty grep not matching a split error message a > > number of times :-( I know by now to remove words

Re: [HACKERS] Subscription code improvements

2017-08-02 Thread Tom Lane
Alvaro Herrera writes: > I wish you'd stop splitting error message strings across multiple lines. > I've been trapped by a faulty grep not matching a split error message a > number of times :-( I know by now to remove words until I get a match, > but it seems an

Re: [HACKERS] Subscription code improvements

2017-08-02 Thread Alvaro Herrera
Petr Jelinek wrote: > I split it into several patches: I wish you'd stop splitting error message strings across multiple lines. I've been trapped by a faulty grep not matching a split error message a number of times :-( I know by now to remove words until I get a match, but it seems an

Re: [HACKERS] Subscription code improvements

2017-08-02 Thread Peter Eisentraut
On 8/1/17 00:17, Noah Misch wrote: > The above-described topic is currently a PostgreSQL 10 open item. Peter, > since you committed the patch believed to have created it, you own this open > item. If some other commit is more relevant or if this does not belong as a > v10 open item, please let

Re: [HACKERS] Subscription code improvements

2017-07-31 Thread Noah Misch
On Fri, Jul 07, 2017 at 10:19:19PM +0200, Petr Jelinek wrote: > I have done some review of subscription handling (well self-review) and > here is the result of that (It's slightly improved version from another > thread [1]). > Only the 0002, 0004 and 0005 are actual bug fixes, but I'd still like

Re: [HACKERS] Subscription code improvements

2017-07-13 Thread Masahiko Sawada
On Wed, Jul 12, 2017 at 11:19 AM, Masahiko Sawada wrote: > On Sat, Jul 8, 2017 at 5:19 AM, Petr Jelinek > wrote: >> Hi, >> >> I have done some review of subscription handling (well self-review) and >> here is the result of that (It's slightly

Re: [HACKERS] Subscription code improvements

2017-07-11 Thread Masahiko Sawada
On Sat, Jul 8, 2017 at 5:19 AM, Petr Jelinek wrote: > Hi, > > I have done some review of subscription handling (well self-review) and > here is the result of that (It's slightly improved version from another > thread [1]). Thank you for working on this and patches!

[HACKERS] Subscription code improvements

2017-07-07 Thread Petr Jelinek
Hi, I have done some review of subscription handling (well self-review) and here is the result of that (It's slightly improved version from another thread [1]). I split it into several patches: 0001 - Makes subscription worker exit nicely when there is subscription missing (ie was removed while