Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Tue, Jan 17, 2017 at 8:11 PM, Magnus Hagander wrote: > Committed. Yeah, thanks! -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Mon, Jan 16, 2017 at 1:46 PM, Michael Paquier wrote: > On Mon, Jan 16, 2017 at 9:12 PM, Magnus Hagander > wrote: > > Where did your research point to then? :) I just read the gzip rfc > > (http://www.zlib.org/rfc-gzip.html) which seems to call

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Mon, Jan 16, 2017 at 9:12 PM, Magnus Hagander wrote: > Where did your research point to then? :) I just read the gzip rfc > (http://www.zlib.org/rfc-gzip.html) which seems to call it that at least? Well, OK. I was not aware of this RFC. I guessed it by looking at the code

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Sun, Jan 15, 2017 at 6:44 AM, Michael Paquier wrote: > On Sun, Jan 15, 2017 at 1:31 AM, Magnus Hagander > wrote: > > > > > > On Tue, Jan 10, 2017 at 3:01 AM, Michael Paquier < > michael.paqu...@gmail.com> > > wrote: > >> Based on some analysis,

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Sun, Jan 15, 2017 at 1:31 AM, Magnus Hagander wrote: > > > On Tue, Jan 10, 2017 at 3:01 AM, Michael Paquier > wrote: >> Based on some analysis, it is enough to look at the last 4 bytes of >> the compressed file to get the size output data with a

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Tue, Jan 10, 2017 at 3:01 AM, Michael Paquier wrote: > On Sat, Jan 7, 2017 at 8:19 PM, Magnus Hagander > wrote: > > On Sat, Jan 7, 2017 at 12:31 AM, Michael Paquier < > michael.paqu...@gmail.com> > > wrote: > >> There is something I forgot.

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Sat, Jan 7, 2017 at 8:19 PM, Magnus Hagander wrote: > On Sat, Jan 7, 2017 at 12:31 AM, Michael Paquier > wrote: >> There is something I forgot. With this patch, >> FindStreamingStart()@pg_receivexlog.c is actually broken. In short it >> forgets

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Sat, Jan 7, 2017 at 12:31 AM, Michael Paquier wrote: > On Fri, Jan 6, 2017 at 11:07 PM, Magnus Hagander > wrote: > > A few further notes: > > Thanks for the review. > > > You are using the filemode to gzopen and the mode_compression variable to

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Fri, Jan 6, 2017 at 11:07 PM, Magnus Hagander wrote: > A few further notes: Thanks for the review. > You are using the filemode to gzopen and the mode_compression variable to > set the compression level. The pre-existing code in pg_basebackup uses > gzsetparams(). Is

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On 1/6/17 9:07 AM, Magnus Hagander wrote: On Fri, Dec 30, 2016 at 6:41 AM, Michael Paquier > wrote: Attached is a simplified new version, I have kept the file descriptor as originally done. Note that tests are actually

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Fri, Dec 30, 2016 at 6:41 AM, Michael Paquier wrote: > On Thu, Dec 29, 2016 at 6:13 PM, Magnus Hagander > wrote: > > On Thu, Dec 29, 2016 at 12:35 AM, Michael Paquier > > wrote: > >> On Wed, Dec 28, 2016 at 9:31 PM,

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Thu, Dec 29, 2016 at 6:13 PM, Magnus Hagander wrote: > On Thu, Dec 29, 2016 at 12:35 AM, Michael Paquier > wrote: >> On Wed, Dec 28, 2016 at 9:31 PM, Magnus Hagander >> wrote: >> >> - I have switched the directory method to

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Thu, Dec 29, 2016 at 12:35 AM, Michael Paquier wrote: > On Wed, Dec 28, 2016 at 9:31 PM, Magnus Hagander > wrote: > > Conditional tests? It probably wouldn't hurt to have them, but that > would be > > something more generic (like we'd need

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Wed, Dec 28, 2016 at 9:31 PM, Magnus Hagander wrote: > Conditional tests? It probably wouldn't hurt to have them, but that would be > something more generic (like we'd need something to actually validate it -- > but it would make sense to have a test that, with compression

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Wed, Dec 28, 2016 at 6:58 AM, Michael Paquier wrote: > On Wed, Dec 28, 2016 at 3:12 AM, Magnus Hagander > wrote: > > On Tue, Dec 27, 2016 at 1:16 PM, Michael Paquier < > michael.paqu...@gmail.com> > > wrote: > >> On Tue, Dec 27, 2016 at 6:34

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Wed, Dec 28, 2016 at 3:12 AM, Magnus Hagander wrote: > On Tue, Dec 27, 2016 at 1:16 PM, Michael Paquier > wrote: >> On Tue, Dec 27, 2016 at 6:34 PM, Magnus Hagander >> wrote: >> > On Tue, Dec 27, 2016 at 2:23 AM, Michael

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Tue, Dec 27, 2016 at 1:16 PM, Michael Paquier wrote: > On Tue, Dec 27, 2016 at 6:34 PM, Magnus Hagander > wrote: > > On Tue, Dec 27, 2016 at 2:23 AM, Michael Paquier < > michael.paqu...@gmail.com> > > wrote: > >> Magnus, you have mentioned me

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Tue, Dec 27, 2016 at 6:34 PM, Magnus Hagander wrote: > On Tue, Dec 27, 2016 at 2:23 AM, Michael Paquier > wrote: >> Magnus, you have mentioned me as well that you had a couple of ideas >> on the matter, feel free to jump in and let's mix our

Re: [HACKERS] Support for pg_receivexlog --format=plain|tar

On Tue, Dec 27, 2016 at 2:23 AM, Michael Paquier wrote: > Hi all, > > Since 56c7d8d4, pg_basebackup supports tar format when streaming WAL > records. This has been done by introducing a new transparent routine > layer to control the method used to fetch WAL

[HACKERS] Support for pg_receivexlog --format=plain|tar

Hi all, Since 56c7d8d4, pg_basebackup supports tar format when streaming WAL records. This has been done by introducing a new transparent routine layer to control the method used to fetch WAL walmethods.c: plain or tar. pg_receivexlog does not make use of that yet, but I think that it could to