Re: [HACKERS] Tablespaces in the data directory

2012-12-04 Thread Noah Misch
On Mon, Dec 03, 2012 at 01:14:30PM -0500, Andrew Dunstan wrote: > I think it would be reasonable for it to complain if it came across a > PG_VERSION file in an unexpected location. That sounds like a reliable approach to detecting the hazard. Pseudocode: chdir(proposed_tablespace_path)

Re: [HACKERS] Tablespaces in the data directory

2012-12-04 Thread Andreas Karlsson
On 2012-12-01 14:45, Magnus Hagander wrote: Someone just reported a problem when they had created a new tablespace inside the old data directory. I'm sure there can be other issues caused by this as well, but this is mainly a confusing scenario for people now. As there isn't (as far as I know at

Re: [HACKERS] Tablespaces in the data directory

2012-12-04 Thread Bruce Momjian
On Tue, Dec 4, 2012 at 09:37:46AM -0500, Robert Haas wrote: > On Mon, Dec 3, 2012 at 10:06 PM, Bruce Momjian wrote: > > FYI, someone put their new cluster inside an existing old tablespace, > > and when they ran the script to delete their old install, their new > > install was deleted too. My an

Re: [HACKERS] Tablespaces in the data directory

2012-12-04 Thread Robert Haas
On Mon, Dec 3, 2012 at 10:06 PM, Bruce Momjian wrote: > FYI, someone put their new cluster inside an existing old tablespace, > and when they ran the script to delete their old install, their new > install was deleted too. My answer was, "Don't do that". Uh, wow. I feel bad for that person, but

Re: [HACKERS] Tablespaces in the data directory

2012-12-03 Thread Michael Glaesemann
On Dec 3, 2012, at 12:33, Magnus Hagander wrote: > On Dec 3, 2012 2:55 AM, "Andrew Dunstan" wrote: >> >> >> On 12/02/2012 07:50 PM, Magnus Hagander wrote: >>> >>> On Sat, Dec 1, 2012 at 6:56 PM, Tom Lane wrote: Magnus Hagander writes: > > Someone just reported a problem

Re: [HACKERS] Tablespaces in the data directory

2012-12-03 Thread Bruce Momjian
On Mon, Dec 3, 2012 at 02:38:20AM -, Greg Sabino Mullane wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: RIPEMD160 > > > > As there isn't (as far as I know at least) any actual *point* in > > creating a tablespace inside the main data directory, should we > > perhaps disallow this in

Re: [HACKERS] Tablespaces in the data directory

2012-12-03 Thread Andrew Dunstan
On 12/03/2012 12:33 PM, Magnus Hagander wrote: On Dec 3, 2012 2:55 AM, "Andrew Dunstan" > wrote: > > > On 12/02/2012 07:50 PM, Magnus Hagander wrote: >> >> On Sat, Dec 1, 2012 at 6:56 PM, Tom Lane > wrote: >>> >>> Magnus Hagander mailto:

Re: [HACKERS] Tablespaces in the data directory

2012-12-03 Thread Magnus Hagander
On Dec 3, 2012 2:55 AM, "Andrew Dunstan" wrote: > > > On 12/02/2012 07:50 PM, Magnus Hagander wrote: >> >> On Sat, Dec 1, 2012 at 6:56 PM, Tom Lane wrote: >>> >>> Magnus Hagander writes: Someone just reported a problem when they had created a new tablespace inside the old data dir

Re: [HACKERS] Tablespaces in the data directory

2012-12-02 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 > As there isn't (as far as I know at least) any actual *point* in > creating a tablespace inside the main data directory, should we > perhaps disallow this in CREATE TABLESPACE? Or at least throw a > WARNING if one does it? Sure there is a poi

Re: [HACKERS] Tablespaces in the data directory

2012-12-02 Thread Andrew Dunstan
On 12/02/2012 07:50 PM, Magnus Hagander wrote: On Sat, Dec 1, 2012 at 6:56 PM, Tom Lane wrote: Magnus Hagander writes: Someone just reported a problem when they had created a new tablespace inside the old data directory. I'm sure there can be other issues caused by this as well, but this is

Re: [HACKERS] Tablespaces in the data directory

2012-12-02 Thread Magnus Hagander
On Sat, Dec 1, 2012 at 6:56 PM, Tom Lane wrote: > Magnus Hagander writes: >> Someone just reported a problem when they had created a new tablespace >> inside the old data directory. I'm sure there can be other issues >> caused by this as well, but this is mainly a confusing scenario for >> people

Re: [HACKERS] Tablespaces in the data directory

2012-12-01 Thread Tom Lane
Magnus Hagander writes: > Someone just reported a problem when they had created a new tablespace > inside the old data directory. I'm sure there can be other issues > caused by this as well, but this is mainly a confusing scenario for > people now. > As there isn't (as far as I know at least) any

Re: [HACKERS] Tablespaces in the data directory

2012-12-01 Thread Simon Riggs
On 1 December 2012 13:45, Magnus Hagander wrote: > Someone just reported a problem when they had created a new tablespace > inside the old data directory. I'm sure there can be other issues > caused by this as well, but this is mainly a confusing scenario for > people now. > > As there isn't (as f

[HACKERS] Tablespaces in the data directory

2012-12-01 Thread Magnus Hagander
Someone just reported a problem when they had created a new tablespace inside the old data directory. I'm sure there can be other issues caused by this as well, but this is mainly a confusing scenario for people now. As there isn't (as far as I know at least) any actual *point* in creating a table